Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate duplicate css #23

Open
furstenberg opened this issue Oct 8, 2018 · 2 comments
Open

Investigate duplicate css #23

furstenberg opened this issue Oct 8, 2018 · 2 comments

Comments

@furstenberg
Copy link
Contributor

A recent MR from CIA had duplicate css from the Prometheus button component in their bundle css.

We need to investigate why this happens.
@plumpNation
Copy link
Contributor

There should be 2 branches with 2 different techniques to solve this already in this repo. es-import-scss-once and import-scss-once. It's kind of nice to have the scss only version, but it puts extra code into your scss files that you may not want. I think I stole the idea from zurb. It was a while ago.

@furstenberg
Copy link
Contributor Author

Yeah, I haven't had time to investigate further. There were duplicate scss for prom-button.

But your branches are still there and it's on my todo-list to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@furstenberg @plumpNation