Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nested module graphs #54

Open
1 of 3 tasks
npars opened this issue Jan 21, 2025 · 0 comments
Open
1 of 3 tasks

Support for nested module graphs #54

npars opened this issue Jan 21, 2025 · 0 comments

Comments

@npars
Copy link

npars commented Jan 21, 2025

⚠️ Is your feature request related to a problem? Please describe

When you have some nested and some non-nested modules the graph becomes messy when showFullPath = false. Ideally a subgraph would be nested within any existing parent graphs.

💡 Describe the solution you'd like

Support for nesting modules in the graph. Possibly via a config boolean, or enabled by default.

Here is what currently is produced:

%%{
  init: {
    'theme': 'neutral'
  }
}%%

graph LR
  subgraph :libs
    :libs:app-common["app-common"]
  end
  subgraph :libs:crash-reporting
    :libs:crash-reporting:api["api"]
    :libs:crash-reporting:firebase["firebase"]
  end
  :App --> :libs:app-common
  :App --> :libs:crash-reporting:api
  :App --> :libs:crash-reporting:firebase
classDef focus fill:#769566,stroke:#fff,stroke-width:2px,color:#fff;
class :App focus
Loading

Here is what I would like if nesting modules is enabled:

%%{
  init: {
    'theme': 'neutral'
  }
}%%

graph LR
  subgraph :libs
    :libs:app-common["app-common"]
    subgraph :crash-reporting
      :libs:crash-reporting:api["api"]
      :libs:crash-reporting:firebase["firebase"]
    end
  end
  :App --> :libs:app-common
  :App --> :libs:crash-reporting:api
  :App --> :libs:crash-reporting:firebase
classDef focus fill:#769566,stroke:#fff,stroke-width:2px,color:#fff;
class :App focus
Loading

🤚 Do you want to develop this feature yourself?

  • Yes
  • No
  • Maybe if I find some time 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant