Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to react v19 #408

Open
ivmartel opened this issue Jan 31, 2025 · 4 comments
Open

Update to react v19 #408

ivmartel opened this issue Jan 31, 2025 · 4 comments
Assignees
@hunxjunedo
Labels
enhancement New feature or request
Milestone
0.10.0

Comments

@ivmartel
Copy link
Owner

ivmartel commented Jan 31, 2025 •
edited
Loading

React v19 is out, see https://react.dev/blog/2024/12/05/react-19
@ivmartel ivmartel added the enhancement New feature or request label Jan 31, 2025
@ivmartel ivmartel added this to the 0.10.0 milestone Jan 31, 2025
@ivmartel ivmartel mentioned this issue Jan 31, 2025
Closed
@hunxjunedo
Copy link

requesting assignment.

@ivmartel
Copy link
Owner Author

ivmartel commented Jan 31, 2025 •
edited
Loading

All comments on the existing code are welcome!

@ivmartel
Copy link
Owner Author

Not sure if it is possible but I would also be interested in publishing this demo as a react component, something people could get from npm and integrate in an existing app. Similar to what I did in dwv-simplistic (#145) or dwv-angular (#873).

@hunxjunedo
Copy link

@ivmartel btw, I'd also like to propose the codebase to be updated to use react functional components instead of the class ones, for cleaner code, also it'd be easier to migrate to react 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hunxjunedo hunxjunedo

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@ivmartel @hunxjunedo