New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there is a logic error in the class NonFizzBuzzRule of Tutorials "Fizz Buzz" #417

Open

jony0113 opened this issue Oct 23, 2023 · 0 comments

jony0113 commented Oct 23, 2023 •

edited

Loading

@condition
public boolean isNotFizzNorBuzz(@fact("number") Integer number) {
// can return true, because this is the latest rule to trigger according to assigned priorities
// and in which case, the number is not fizz nor buzz
return number % 5 != 0 || number % 7 != 0;
}

should be

return number % 5 != 0 && number % 7 != 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment