Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin server in the collector no longer uses keep-alive flag #6341

Open
yurishkuro opened this issue Dec 11, 2024 · 2 comments
Open

Zipkin server in the collector no longer uses keep-alive flag #6341

yurishkuro opened this issue Dec 11, 2024 · 2 comments

Comments

@yurishkuro
Copy link
Member

https://github.com/jaegertracing/jaeger/pull/6277/files#r1881105558
@yurishkuro yurishkuro mentioned this issue Dec 11, 2024
Merged
4 tasks
@dosubot dosubot bot added the changelog:breaking-change Change that is breaking public APIs or established behavior label Dec 11, 2024
@yurishkuro
Copy link
Member Author

yurishkuro commented Dec 11, 2024 •
edited
Loading

In cmd/collector/app/server/http.go we can call server.SetKeepAlivesEnabled(true), but that doesn't affect Zipkin receiver.

@yurishkuro yurishkuro removed the changelog:breaking-change Change that is breaking public APIs or established behavior label Dec 11, 2024
@yurishkuro
Copy link
Member Author

Related Collector issue open-telemetry/opentelemetry-collector#9211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurishkuro