Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implement proper payload chunked encoding in HTTP api_v3 #6479

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] Implement proper payload chunked encoding in HTTP api_v3 #6479

wants to merge 4 commits into from
+44 −1

Conversation

chahatsagarmain
Copy link
Contributor

@chahatsagarmain chahatsagarmain commented Jan 4, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Added a handler function

How was this change tested?

Checklist

@chahatsagarmain
content encoding
a37e7fd 
Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain
remove print statement
2746692 
Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain chahatsagarmain requested a review from a team as a code owner January 4, 2025 12:47
@chahatsagarmain chahatsagarmain marked this pull request as draft January 4, 2025 12:54
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.25%. Comparing base (e7a0205) to head (cdefef7).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
cmd/query/app/apiv3/http_gateway.go 77.77% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6479      +/-   ##
==========================================
+ Coverage   96.23%   96.25%   +0.02%     
==========================================
  Files         368      370       +2     
  Lines       20978    21201     +223     
==========================================
+ Hits        20189    20408     +219     
- Misses        604      607       +3     
- Partials      185      186       +1
Flag Coverage Δ
badger_v1 10.74% <ø> (+0.17%) ⬆️
badger_v2 2.80% <ø> (+0.37%) ⬆️
cassandra-4.x-v1-manual 16.62% <ø> (+0.16%) ⬆️
cassandra-4.x-v2-auto 2.73% <ø> (+0.37%) ⬆️
cassandra-4.x-v2-manual 2.73% <ø> (+0.37%) ⬆️
cassandra-5.x-v1-manual 16.62% <ø> (+0.16%) ⬆️
cassandra-5.x-v2-auto 2.73% <ø> (+0.37%) ⬆️
cassandra-5.x-v2-manual 2.73% <ø> (+0.37%) ⬆️
elasticsearch-6.x-v1 20.31% <ø> (+0.12%) ⬆️
elasticsearch-7.x-v1 20.39% <ø> (+0.12%) ⬆️
elasticsearch-8.x-v1 20.55% <ø> (+0.12%) ⬆️
elasticsearch-8.x-v2 2.79% <ø> (+0.37%) ⬆️
grpc_v1 12.39% <ø> (+0.17%) ⬆️
grpc_v2 9.15% <ø> (+0.34%) ⬆️
kafka-3.x-v1 10.58% <ø> (+0.17%) ⬆️
kafka-3.x-v2 2.80% <ø> (+0.37%) ⬆️
memory_v2 2.80% <ø> (+0.37%) ⬆️
opensearch-1.x-v1 20.43% <ø> (+0.11%) ⬆️
opensearch-2.x-v1 20.43% <ø> (+0.11%) ⬆️
opensearch-2.x-v2 2.79% <ø> (+0.37%) ⬆️
tailsampling-processor 0.52% <ø> (+0.12%) ⬆️
unittests 95.13% <77.77%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chahatsagarmain
minor change
c62346f 
Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain
read chunked response
cdefef7 
Signed-off-by: chahatsagarmain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement proper payload chunked encoding in HTTP api_v3
1 participant
@chahatsagarmain