-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Persistence test remote logging failures when running the ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest test #1497
Comments
This could be related to #1406 , as we need to try to regain as much logging from the javatest classes as possible to help not only debugging the port, but for TCK users. |
I'm going to try updating my local ts.jte properties to set harness.log.traceflag=true so that the connection properties are logged as per #1501 the connection is timing out. |
The TCK test runner side call stack as randomly captured by jstack looks like:
|
I'm going to let the tests run for a bit but we likely have a protocol error to fix with one side not in sync with what the other side is sending/receiving. Tests results in progress:
|
Looks like https://github.com/jakartaee/platform-tck/blob/main/libutil/src/main/java/com/sun/ts/lib/util/TestUtil.java#L285 is sending an exception |
Class ee.jakarta.tck.persistence.core.types.generator.Client4PuservletTest extends ee.jakarta.tck.persistence.core.types.generator.Client4 and ee.jakarta.tck.persistence.core.types.generator.Client4 extends ee.jakarta.tck.persistence.core.types.generator.Client and ee.jakarta.tck.persistence.core.types.generator.Client extends ee.jakarta.tck.persistence.common.PMClientBase and ee.jakarta.tck.persistence.common.PMClientBase extends com.sun.ts.lib.harness.ServiceEETest Currently, we are getting a
|
We also need to add super class |
The exception that we see on the EE implementation side is:
|
Ok, this is another jpa refactor issue. The EE10 build does not know about the new classes, so whenever the EE11toEE10Mapping#addTestClassMapping is needed, we need to add the Class in addition to the ClassN to the war or appclient. |
One change that is missing that I manually made to get further:
|
Another problem is that we are passing property "test_classname" -> "ee.jakarta.tck.persistence.core.EntityGraph.Client" but that should be ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest which seems similar to previous comment issue. |
eclipse-ee4j/jakartaee-tck-tools#133 is responsible for the incorrect test_classname but that seems like a different problem then the missing Added eclipse-ee4j/jakartaee-tck-tools#134 for the missing |
A third issue is with the "harness.host" property accessed in https://github.com/jakartaee/platform-tck/blob/main/libutil/src/main/java/com/sun/ts/lib/util/TestUtil.java#L445 being an ip address (e.g. 10.5.22.94) that isn't quite as good as "localhost" would be for my local machine. With Locally, The code in the Platform TCK LibUtil.java My local /etc/hosts file only contains:
I think that harness.log.port should not be set to |
I think we should allow users to specify the Created #1505 for adding |
I see this on EE 10 as well. |
The text was updated successfully, but these errors were encountered: