Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Opengraph Support #89

Open
ProfessorLogout opened this issue Jul 17, 2020 · 3 comments
Open

Advanced Opengraph Support #89

ProfessorLogout opened this issue Jul 17, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ProfessorLogout
Copy link
Contributor

As discussed in #82
For the moment just some quick notes on how we can do this:

  • Extract the twitter & other open graph like tags from baseof.html into a file like opengraph.html
  • Replicate current behavior in opengraph.html
  • Overwrite opengraph.html in https://github.com/msfjarvis/hugo-social-metadata bringing more advanced features
  • Telling users to submodule hugo-social-metadata and place it before codex in themes ( form my experience this works) to get enhanced behavior

This are just some quick notes early in the morning from mobile, excuse my formatting.
Happy for comments, I will update once I can try this later today.

@msfjarvis @jakewies

@msfjarvis
Copy link
Contributor

Looks good, happy to help with any changes to my module.

@jakewies
Copy link
Owner

jakewies commented Jul 17, 2020

Would this mean that hugo-social-metadata would need to be refactored to include an opengraph.html template in order to override the opengraph.html template in the theme?

Just peaked into @msfjarvis project and the template is named social_metadata.html.

I'm on board with this. The first two steps wouldn't include any new changes to this project other than prepping for optional functionality from hugo-social-metadata. We would need to update the README to document how it's done.

It would also mean changing our documentation on how to install this project I think? Since now we document adding it as a git submodule instead of a Hugo module.

EDIT: Sorry on mobile, now I see we can tell users to submodule both themes and just declare them as normal but put hugo-social-metadata first. Got it. I wouldn't mind considering Hugo modules as an additional improvement here. What do you all think about the submodule vs Hugo module declaration approach?

@jakewies jakewies added the enhancement New feature or request label Jul 20, 2020
@iamericfletcher
Copy link

Would this mean that hugo-social-metadata would need to be refactored to include an opengraph.html template in order to override the opengraph.html template in the theme?

Just peaked into @msfjarvis project and the template is named social_metadata.html.

I'm on board with this. The first two steps wouldn't include any new changes to this project other than prepping for optional functionality from hugo-social-metadata. We would need to update the README to document how it's done.

It would also mean changing our documentation on how to install this project I think? Since now we document adding it as a git submodule instead of a Hugo module.

EDIT: Sorry on mobile, now I see we can tell users to submodule both themes and just declare them as normal but put hugo-social-metadata first. Got it. I wouldn't mind considering Hugo modules as an additional improvement here. What do you all think about the submodule vs Hugo module declaration approach?

Looking forward to using and sharing this enhancement. Thank you.

@jakewies jakewies added the help wanted Extra attention is needed label Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants