Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with axios 1.7.9 #1854

Open
ronaldcreutz-vw opened this issue Dec 5, 2024 · 1 comment
Open

Not compatible with axios 1.7.9 #1854

ronaldcreutz-vw opened this issue Dec 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ronaldcreutz-vw
Copy link

Thanks a lot for that helpful library to the contributers!

Since the last update of axios library to 1.7.9 the aws4-axios interceptor isn't compatible and build fails.

e.g.
Argument of type '(config: InternalAxiosRequestConfig) => Promise<InternalAxiosRequestConfig>' is not assignable to parameter of type '(value: InternalAxiosRequestConfig) => InternalAxiosRequestConfig | Promise<InternalAxiosRequestConfig>'.
Types of parameters 'config' and 'value' are incompatible.

@jamesmbourne
Copy link
Owner

Hey @ronaldcreutz-vw, thanks for reporting the issue.

The InternalAxiosRequestConfig type is re-used from axios, so I'm not sure how there's a type mismatch here.

Are you able to provide a minimal reproducible example? I have upgraded to 1.7.9 locally and I'm unable to see any type errors.

@jamesmbourne jamesmbourne added the bug Something isn't working label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants