Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace moment.js with maintaned date library #678

Open
ad-m opened this issue Feb 11, 2021 · 2 comments · May be fixed by #806
Open

replace moment.js with maintaned date library #678

ad-m opened this issue Feb 11, 2021 · 2 comments · May be fixed by #806
Labels
contributors welcome

Comments

@ad-m
Copy link
Contributor

ad-m commented Feb 11, 2021 •
edited
Loading

Looks like moment is moving towards deprecation. Could probably replace it with date-fns or luxon or some other more actively maintained library. We use it exclusively for date validation in the tests so it's not urgent.

Originally posted by @leontastic in #663 (comment)

Could somebody add labels about "contributors welcome"?
@jamhall
Copy link
Owner

jamhall commented Feb 11, 2021 •
edited
Loading

@ad-m - Added the label :) EDIT: You mean project labels or issue labels?

@ad-m
Copy link
Contributor Author

ad-m commented Feb 11, 2021

@jamhall , issue label. I think this is an excellent topic for someone who has a basic understanding of JavaScript and would like to contribute to this project.

@umutiq umutiq linked a pull request Dec 1, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributors welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace moment with dayjs umutiq/s3rver
2 participants
@jamhall @ad-m