We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/metasys-server/basic-services-dotnet/blob/f1d936984908af6b5e4640f35d514281a97a279f/MetasysServices/Models/Variant.cs#L151
I think this points to the fact that Variant should be decomposed into two types.
Variant
AttributeValue
Then Variant is appropriate to use for property values as well as cells in an array. AttributeValue would be used only for property values.
The text was updated successfully, but these errors were encountered:
If you do this decomposition, then Variant could have an internal Factory method that takes a JToken for use by MetasysClient.
JToken
MetasysClient
But it could also have implicit conversion operators to convert numbers, bools, strings, etc to Variant. For convenience, and testing.
So you could do things like the following.
var v:Variant = 35 var x:Variant = "My string"
Or just have public constructors that take all the basic types that need to be supported.
Sorry, something went wrong.
@Federico-Artioli something to consider.
No branches or pull requests
https://github.com/metasys-server/basic-services-dotnet/blob/f1d936984908af6b5e4640f35d514281a97a279f/MetasysServices/Models/Variant.cs#L151
I think this points to the fact that
Variant
should be decomposed into two types.Variant
which is a type that can hold one of String, Number, Boolean, or Array.AttributeValue
which holds an id, attribute, Variant, (and culture for localization)Then
Variant
is appropriate to use for property values as well as cells in an array.AttributeValue
would be used only for property values.The text was updated successfully, but these errors were encountered: