Skip to content

Commit 4755540

Browse files
committed
Java 17: upgrade to Java 17
- Add TODO notes - Turn off pegdown for now (need replacement)
1 parent 9c6b3eb commit 4755540

File tree

7 files changed

+38
-11
lines changed

7 files changed

+38
-11
lines changed

.github/workflows/build-matrix.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
strategy:
99
fail-fast: false
1010
matrix:
11-
java_version: [1.8, 11, 15]
11+
java_version: [1.8, 11, 15, 17]
1212
os: [ubuntu-latest, windows-latest, macOS-latest]
1313

1414
steps:

TODO

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Java 15/17 Migration
2+
3+
- Replace pegdown with something else
4+
- Upgrade spring

handlebars-markdown/pom.xml

+19
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,25 @@
4646
<scope>test</scope>
4747
</dependency>
4848

49+
<dependency>
50+
<groupId>org.antlr</groupId>
51+
<artifactId>antlr4-runtime</artifactId>
52+
<version>4.9.2</version>
53+
<exclusions>
54+
<exclusion>
55+
<groupId>org.abego.treelayout</groupId>
56+
<artifactId>org.abego.treelayout.core</artifactId>
57+
</exclusion>
58+
</exclusions>
59+
<scope>test</scope>
60+
</dependency>
61+
62+
<dependency>
63+
<groupId>org.apache.commons</groupId>
64+
<artifactId>commons-text</artifactId>
65+
<scope>test</scope>
66+
</dependency>
67+
4968
</dependencies>
5069

5170
</project>

handlebars-maven-plugin-tests/pom.xml

+6
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@
4141
</executions>
4242
</plugin>
4343

44+
<plugin>
45+
<groupId>org.apache.maven.plugins</groupId>
46+
<artifactId>maven-war-plugin</artifactId>
47+
<version>3.3.2</version>
48+
</plugin>
49+
4450
<!-- Deploy plugin -->
4551
<plugin>
4652
<groupId>org.apache.maven.plugins</groupId>

handlebars-proto/pom.xml

+5-5
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,11 @@
124124
<version>${project.version}</version>
125125
</dependency>
126126

127-
<dependency>
128-
<groupId>com.github.jknack</groupId>
129-
<artifactId>handlebars-markdown</artifactId>
130-
<version>${project.version}</version>
131-
</dependency>
127+
<!-- <dependency>-->
128+
<!-- <groupId>com.github.jknack</groupId>-->
129+
<!-- <artifactId>handlebars-markdown</artifactId>-->
130+
<!-- <version>${project.version}</version>-->
131+
<!-- </dependency>-->
132132

133133
<dependency>
134134
<groupId>com.github.jknack</groupId>

handlebars-proto/src/main/java/com/github/jknack/handlebars/server/HbsServer.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,9 @@
4343
import org.slf4j.LoggerFactory;
4444

4545
import com.github.jknack.handlebars.Handlebars;
46-
import com.github.jknack.handlebars.Helper;
4746
import com.github.jknack.handlebars.HelperRegistry;
4847
import com.github.jknack.handlebars.HumanizeHelper;
4948
import com.github.jknack.handlebars.Jackson2Helper;
50-
import com.github.jknack.handlebars.MarkdownHelper;
5149
import com.github.jknack.handlebars.helper.StringHelpers;
5250
import com.github.jknack.handlebars.io.FileTemplateLoader;
5351
import com.github.jknack.handlebars.io.TemplateLoader;
@@ -169,7 +167,7 @@ public static void run(final Options args) throws Exception {
169167
(context, options) -> new Handlebars.SafeString(options.fn.text())
170168
);
171169
handlebars.registerHelper("json", Jackson2Helper.INSTANCE);
172-
handlebars.registerHelper("md", new MarkdownHelper());
170+
// handlebars.registerHelper("md", new MarkdownHelper());
173171
// String helpers
174172
StringHelpers.register(handlebars);
175173
// Humanize helpers

pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<module>handlebars-helpers</module>
1818
<!-- <module>handlebars-springmvc</module>-->
1919
<module>handlebars-jackson2</module>
20-
<module>handlebars-markdown</module>
20+
<!-- <module>handlebars-markdown</module>-->
2121
<module>handlebars-humanize</module>
2222
<module>handlebars-proto</module>
2323
<module>handlebars-guava-cache</module>
@@ -271,7 +271,7 @@
271271
<plugin>
272272
<groupId>org.apache.maven.plugins</groupId>
273273
<artifactId>maven-deploy-plugin</artifactId>
274-
<version>2.8.2</version>
274+
<version>3.0.0-M1</version>
275275
</plugin>
276276

277277
</plugins>

0 commit comments

Comments
 (0)