Improve Ruby performance by freezing strings

lukeseawalker · lukeseawalker · commit 1c516d7db60e · 2019-10-23T10:08:32.000+02:00
https://bugs.ruby-lang.org/issues/11473 https://bugs.ruby-lang.org/issues/8976 Signed-off-by: Luca Carrogu <carrogu@amazon.com>
diff --git a/Berksfile b/Berksfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://supermarket.chef.io'
 
 metadata
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'berkshelf'
diff --git a/Rakefile b/Rakefile
@@ -1,4 +1,5 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
 
 # chefspec task against spec/*_spec.rb
 require 'rspec/core/rake_task'
diff --git a/attributes/default.rb b/attributes/default.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Attributes:: default
diff --git a/libraries/helpers.rb b/libraries/helpers.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'chef/mixin/shell_out'
 require 'net/http'
 require 'timeout'
diff --git a/metadata.rb b/metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 name 'aws-parallelcluster'
 maintainer 'Amazon Web Services'
 maintainer_email ''
diff --git a/recipes/_compute_base_config.rb b/recipes/_compute_base_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _compute_base_config
diff --git a/recipes/_compute_custom_config.rb b/recipes/_compute_custom_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _compute_custom_config
diff --git a/recipes/_compute_sge_config.rb b/recipes/_compute_sge_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _compute_sge_config
diff --git a/recipes/_compute_slurm_config.rb b/recipes/_compute_slurm_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _compute_slurm_config
diff --git a/recipes/_compute_torque_config.rb b/recipes/_compute_torque_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _compute_torque_config
diff --git a/recipes/_default_pre.rb b/recipes/_default_pre.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _default_pre
diff --git a/recipes/_ec2_udev_rules.rb b/recipes/_ec2_udev_rules.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _ec2_udev_rules
diff --git a/recipes/_efa_install.rb b/recipes/_efa_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _efa_install
diff --git a/recipes/_ganglia_install.rb b/recipes/_ganglia_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _ganglia_install
diff --git a/recipes/_lustre_install.rb b/recipes/_lustre_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _lustre_install
diff --git a/recipes/_master_base_config.rb b/recipes/_master_base_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _master_base_config
diff --git a/recipes/_master_custom_config.rb b/recipes/_master_custom_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _master_custom_config
diff --git a/recipes/_master_sge_config.rb b/recipes/_master_sge_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _master_sge_config
diff --git a/recipes/_master_slurm_config.rb b/recipes/_master_slurm_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _master_slurm_config
diff --git a/recipes/_master_torque_config.rb b/recipes/_master_torque_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _master_torque_config
diff --git a/recipes/_nvidia_install.rb b/recipes/_nvidia_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _nvidia_install
diff --git a/recipes/_prep_env.rb b/recipes/_prep_env.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _prep_env
diff --git a/recipes/_setup_python.rb b/recipes/_setup_python.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _setup_python
@@ -48,4 +50,4 @@
   virtualenv "#{node['cfncluster']['cookbook_virtualenv_path']}"
   requirement true
   user 'root'
-end
+end
diff --git a/recipes/_undo_base_config.rb b/recipes/_undo_base_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _undo_base_config
diff --git a/recipes/_undo_master_base_config.rb b/recipes/_undo_master_base_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _undo_master_base_config
diff --git a/recipes/_update_packages.rb b/recipes/_update_packages.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: _update_packages
diff --git a/recipes/awsbatch_config.rb b/recipes/awsbatch_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: aws_batch_config
diff --git a/recipes/base_config.rb b/recipes/base_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: base_config
diff --git a/recipes/base_install.rb b/recipes/base_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: base_install
diff --git a/recipes/custom_config.rb b/recipes/custom_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: custom_config
diff --git a/recipes/custom_install.rb b/recipes/custom_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: custom_install
diff --git a/recipes/default.rb b/recipes/default.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: default
diff --git a/recipes/efs_mount.rb b/recipes/efs_mount.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: efs_mount
diff --git a/recipes/finalize.rb b/recipes/finalize.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: finalize
diff --git a/recipes/fsx_mount.rb b/recipes/fsx_mount.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: fsx_mount
diff --git a/recipes/image_prep.rb b/recipes/image_prep.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: image_prep
diff --git a/recipes/intel_install.rb b/recipes/intel_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: intel_install
@@ -78,4 +80,4 @@
 create_modulefile "#{node['cfncluster']['modulefile_dir']}/intelpsxe" do
   source_path "/opt/intel/psxe_runtime/linux/bin/psxevars.sh"
   modulefile "#{node['cfncluster']['psxe']['version']}"
-end
+end
diff --git a/recipes/intel_mpi.rb b/recipes/intel_mpi.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: intel_mpi
@@ -42,4 +44,4 @@
   execute 'yum-config-manager_skip_if_unavail_intel_mpi' do
     command "yum-config-manager --save --setopt=intel-mpi.skip_if_unavailable=true"
   end
-end
+end
diff --git a/recipes/munge_install.rb b/recipes/munge_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: munge_install
diff --git a/recipes/setup_raid_on_master.rb b/recipes/setup_raid_on_master.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: setup_raid_on_master
diff --git a/recipes/sge_config.rb b/recipes/sge_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: sge_config
diff --git a/recipes/sge_install.rb b/recipes/sge_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: sge_install
diff --git a/recipes/slurm_config.rb b/recipes/slurm_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: slurm_config
diff --git a/recipes/slurm_install.rb b/recipes/slurm_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: slurm_install
diff --git a/recipes/tests.rb b/recipes/tests.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: tests
diff --git a/recipes/torque_config.rb b/recipes/torque_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: cfnclustr
 # Recipe:: torque_config
diff --git a/recipes/torque_install.rb b/recipes/torque_install.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Cookbook Name:: aws-parallelcluster
 # Recipe:: torque_install
diff --git a/resources/create_modulefile.rb b/resources/create_modulefile.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 resource_name :create_modulefile
 provides :create_modulefile
 
@@ -13,7 +15,6 @@
 default_action :run
 
 action :run do
-
   # Install env2
   env2 = "#{node['cfncluster']['scripts_dir']}/env2"
   remote_file env2 do
@@ -36,4 +37,4 @@
     MODULEFILE
     creates modulefile_path
   end
-end
+end
diff --git a/spec/unit/spec_helper.rb b/spec/unit/spec_helper.rb
@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require 'chefspec'
 require 'chefspec/berkshelf'
diff --git a/test/integration/base_install/serverspec/base_install_spec.rb b/test/integration/base_install/serverspec/base_install_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'serverspec'
 
 set :backend, :exec
diff --git a/test/integration/sge_install/serverspec/sge_install_spec.rb b/test/integration/sge_install/serverspec/sge_install_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'serverspec'
 
 set :backend, :exec

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`source 'https://rubygems.org'`
`2`	`4`
`3`	`5`	`gem 'berkshelf'`