{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":669321707,"defaultBranch":"main","name":"watchman","ownerLogin":"jdelliot","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-07-21T23:21:56.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/8049604?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1700092416.0","currentOid":""},"activityList":{"items":[{"before":"32957aa15d5bb73b26bdea74d8bb87236e35b6db","after":"aeb63e0fc82a8e19d7f4d93234618f35934aba2b","ref":"refs/heads/export-D51321500","pushedAt":"2023-11-29T00:28:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Move sapling_backingstore_get_tree_batch to cxx_bridge\n\nSummary:\nX-link: https://github.com/facebook/folly/pull/2098\n\nX-link: https://github.com/facebook/fbthrift/pull/588\n\ncxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages.\n\nThis moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge.\n\nReviewed By: xavierd\n\nDifferential Revision: D51321500","shortMessageHtmlLink":"Move sapling_backingstore_get_tree_batch to cxx_bridge"}},{"before":"7704ab9e38605776aa425caca4e7a91bed1e02e3","after":"32957aa15d5bb73b26bdea74d8bb87236e35b6db","ref":"refs/heads/export-D51321500","pushedAt":"2023-11-28T21:35:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Move sapling_backingstore_get_tree_batch to cxx_bridge\n\nSummary:\ncxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages.\n\nThis moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge.\n\nReviewed By: xavierd\n\nDifferential Revision: D51321500","shortMessageHtmlLink":"Move sapling_backingstore_get_tree_batch to cxx_bridge"}},{"before":null,"after":"7704ab9e38605776aa425caca4e7a91bed1e02e3","ref":"refs/heads/export-D51321500","pushedAt":"2023-11-15T23:53:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Move sapling_backingstore_get_tree_batch to cxx_bridge\n\nSummary:\nX-link: https://github.com/facebook/mvfst/pull/323\n\nX-link: https://github.com/facebook/hhvm/pull/9413\n\nX-link: https://github.com/facebook/folly/pull/2098\n\nX-link: https://github.com/facebook/fboss/pull/167\n\nX-link: https://github.com/facebookincubator/velox/pull/7595\n\ncxx.rs provides a more ergonomic and opinionated interop layer between Rust and C++ that we would like to leverage for future API chages.\n\nThis moves sapling_backingstore_get_tree_batch from the existing cbindgen implemenation to the new cxxbridge.\n\nReviewed By: xavierd\n\nDifferential Revision: D51321500","shortMessageHtmlLink":"Move sapling_backingstore_get_tree_batch to cxx_bridge"}},{"before":"d56af8fccb9d24b122678bbb9f4eb43a82360db9","after":"45c9c0b071048f4c23fc07bd65fe8cfeee2c9913","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-14T21:12:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function (#1173)\n\nSummary:\nX-link: https://github.com/facebookincubator/hsthrift/pull/120\n\nX-link: https://github.com/facebook/folly/pull/2096\n\nX-link: https://github.com/facebookexperimental/edencommon/pull/14\n\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nReviewed By: xavierd\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function (facebook#1173)"}},{"before":"278444562304fb097fba7662a8e1af24bf6bdf25","after":"d56af8fccb9d24b122678bbb9f4eb43a82360db9","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-13T17:31:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function (#1173)\n\nSummary:\nX-link: https://github.com/facebook/folly/pull/2096\n\nX-link: https://github.com/facebookexperimental/edencommon/pull/14\n\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nReviewed By: xavierd\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function (facebook#1173)"}},{"before":"d385d59b757057f0f92b41893f0e9e4ac97a7ac5","after":"278444562304fb097fba7662a8e1af24bf6bdf25","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-12T06:54:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function (#1173)\n\nSummary:\nX-link: https://github.com/facebookexperimental/edencommon/pull/14\n\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function (facebook#1173)"}},{"before":"0f03724e309806db9c8c3734d00a95b6e8a7de1e","after":"d385d59b757057f0f92b41893f0e9e4ac97a7ac5","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-11T20:20:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function (#1173)\n\nSummary:\nX-link: https://github.com/facebook/mvfst/pull/322\n\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function (facebook#1173)"}},{"before":"911f2a02004012196e7b1998e98cc71d67d1042d","after":"0f03724e309806db9c8c3734d00a95b6e8a7de1e","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-11T20:14:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function (#1173)\n\nSummary:\nX-link: https://github.com/facebookincubator/delos_core/pull/9\n\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function (facebook#1173)"}},{"before":"82f605971882a4bff39ef78aedba9480b8fbf072","after":"911f2a02004012196e7b1998e98cc71d67d1042d","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-11T08:37:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function (#1173)\n\nSummary:\nX-link: https://github.com/facebook/fboss/pull/166\n\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function (facebook#1173)"}},{"before":"40c443f29724fe03cdd310ff3290f84d00188413","after":"82f605971882a4bff39ef78aedba9480b8fbf072","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-10T23:19:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function (#1173)\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/617\n\nX-link: https://github.com/facebookincubator/katran/pull/208\n\nX-link: https://github.com/facebookincubator/fizz/pull/102\n\nX-link: https://github.com/facebookexternal/traffixr/pull/4\n\n\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function (facebook#1173)"}},{"before":null,"after":"40c443f29724fe03cdd310ff3290f84d00188413","ref":"refs/heads/export-D51160627","pushedAt":"2023-11-10T19:59:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Add rust_cxx_bridge CMake function\n\nSummary:\nX-link: https://github.com/facebook/proxygen/pull/473\n\nX-link: https://github.com/facebook/hhvm/pull/9411\n\nX-link: https://github.com/facebook/fbthrift/pull/587\n\nX-link: https://github.com/facebookincubator/velox/pull/7518\n\nWe need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.\n\nThis function creates C++ bindings using the [cxx] crate.\n\nOriginal function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390\n\nDifferential Revision: D51160627","shortMessageHtmlLink":"Add rust_cxx_bridge CMake function"}},{"before":"506efc3781a076fca38aa2c6292373c3be5fb71b","after":"8b2715ed78fc5fee7c5c728db1014b3635fb9ef6","ref":"refs/heads/export-D50772544","pushedAt":"2023-10-30T16:44:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Paramatized rust_static_library to enable CXX support\n\nSummary:\nX-link: https://github.com/facebookincubator/delos_core/pull/8\n\nX-link: https://github.com/facebookincubator/zstrong/pull/610\n\nX-link: https://github.com/facebookincubator/crux/pull/10\n\nX-link: https://github.com/facebookexternal/traffixr/pull/3\n\nX-link: https://github.com/facebookincubator/katran/pull/205\n\nX-link: https://github.com/facebookincubator/fizz/pull/101\n\nX-link: https://github.com/facebook/sapling/pull/763\n\nX-link: https://github.com/facebookexperimental/rust-shed/pull/43\n\nX-link: https://github.com/facebook/wangle/pull/221\n\nX-link: https://github.com/facebook/openr/pull/150\n\nX-link: https://github.com/facebook/hhvm/pull/9403\n\nX-link: https://github.com/facebook/folly/pull/2092\n\nX-link: https://github.com/facebook/fb303/pull/42\n\nX-link: https://github.com/facebookincubator/velox/pull/7301\n\nWe are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.\n\nReviewed By: xavierd\n\nDifferential Revision: D50772544","shortMessageHtmlLink":"Paramatized rust_static_library to enable CXX support"}},{"before":"4311be64dbf1db31c68033857c99a715f3793b98","after":"506efc3781a076fca38aa2c6292373c3be5fb71b","ref":"refs/heads/export-D50772544","pushedAt":"2023-10-29T22:12:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Paramatized rust_static_library to enable CXX support\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/610\n\nX-link: https://github.com/facebookincubator/crux/pull/10\n\nX-link: https://github.com/facebookexternal/traffixr/pull/3\n\nX-link: https://github.com/facebookincubator/katran/pull/205\n\nX-link: https://github.com/facebookincubator/fizz/pull/101\n\nX-link: https://github.com/facebook/sapling/pull/763\n\nX-link: https://github.com/facebookexperimental/rust-shed/pull/43\n\nX-link: https://github.com/facebook/wangle/pull/221\n\nX-link: https://github.com/facebook/openr/pull/150\n\nX-link: https://github.com/facebook/hhvm/pull/9403\n\nX-link: https://github.com/facebook/folly/pull/2092\n\nX-link: https://github.com/facebook/fb303/pull/42\n\nX-link: https://github.com/facebookincubator/velox/pull/7301\n\nWe are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.\n\nDifferential Revision: D50772544","shortMessageHtmlLink":"Paramatized rust_static_library to enable CXX support"}},{"before":null,"after":"4311be64dbf1db31c68033857c99a715f3793b98","ref":"refs/heads/export-D50772544","pushedAt":"2023-10-29T00:14:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdelliot","name":"John Elliott","path":"/jdelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8049604?s=80&v=4"},"commit":{"message":"Paramatized rust_static_library to enable CXX support\n\nSummary:\nX-link: https://github.com/facebook/openr/pull/150\n\nX-link: https://github.com/facebook/hhvm/pull/9403\n\nX-link: https://github.com/facebook/folly/pull/2092\n\nX-link: https://github.com/facebook/fb303/pull/42\n\nX-link: https://github.com/facebookincubator/velox/pull/7301\n\nWe are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.\n\nDifferential Revision: D50772544","shortMessageHtmlLink":"Paramatized rust_static_library to enable CXX support"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADumCOgwA","startCursor":null,"endCursor":null}},"title":"Activity ยท jdelliot/watchman"}