Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing template.html #396

Closed
racerxdl opened this issue Jun 5, 2020 · 27 comments
Closed

Customizing template.html #396

racerxdl opened this issue Jun 5, 2020 · 27 comments

Comments

@racerxdl
Copy link

racerxdl commented Jun 5, 2020

The issue #355 was closed by the bot. But it is useful to customize the template.html.

@jekyllbot

This comment was marked as outdated.

@jekyllbot jekyllbot added the stale label Aug 5, 2020
@racerxdl

This comment was marked as off-topic.

@jekyllbot jekyllbot removed the stale label Sep 30, 2020
@pudiva
Copy link

pudiva commented Oct 16, 2020

bump. I'd really like to customise some logic there:

  • add support for og:video
  • automatically generate image and video urls based on id stored on front-matter
  • reuse social links that are stored in another config key

@pudiva
Copy link

pudiva commented Oct 16, 2020

my hope is that such feature would get into gh-pages, for maximum laziness convenience

@jekyllbot

This comment was marked as outdated.

@racerxdl

This comment was marked as off-topic.

@jekyllbot

This comment was marked as outdated.

@pudiva

This comment was marked as off-topic.

@jekyllbot

This comment was marked as outdated.

@pudiva

This comment was marked as off-topic.

@jekyllbot jekyllbot removed the stale label Apr 16, 2021
@jekyllbot

This comment was marked as outdated.

@pudiva

This comment was marked as off-topic.

@jekyllbot jekyllbot removed the stale label Jun 17, 2021
@davorpa
Copy link

davorpa commented Jul 27, 2021

I think that generator meta tag should be optional (or at least doesn't show version).

It's well-known to be used to know if site has any vulnerability.

The less information is given about frameworks, application servers, libraries ... the better.

@racerxdl
Copy link
Author

Not that it makes much difference for static pages @davorpa , but you're right.

@jekyllbot

This comment was marked as outdated.

@davorpa

This comment was marked as resolved.

@jekyllbot jekyllbot removed the stale label Sep 27, 2021
@jekyllbot

This comment was marked as outdated.

@davorpa

This comment was marked as resolved.

@jekyllbot jekyllbot removed the stale label Nov 28, 2021
@jekyllbot

This comment was marked as outdated.

@racerxdl

This comment was marked as off-topic.

@jekyllbot jekyllbot removed the stale label Jan 28, 2022
@schristm

This comment was marked as off-topic.

@jekyllbot

This comment was marked as outdated.

@davorpa

This comment was marked as resolved.

@jekyllbot

This comment was marked as outdated.

@schristm

This comment was marked as off-topic.

@jekyllbot jekyllbot removed the stale label Jun 16, 2022
@pudiva

This comment was marked as off-topic.

@mattr-
Copy link
Member

mattr- commented Jun 19, 2022

I appreciate y'all keeping this issue alive for two years while somebody eventually comes and looks at it. I'm not closing this issue out of spite, but rather because customizing the template itself is not the right avenue to support the functionality requests y'all have made and I'd rather see more concrete feature requests to pursue what you're after.

I'll follow up in about a week and if nobody's made the issues, I'll create them myself. At least then there will be placeholders for the requests rather than them getting lost. (And when necessary, the whole jekyllbot stale dance can be done on those too. 😄 )

add support for og:video

This feels like a separate feature request that the plugin should support out of the box if the appropriate config keys are present, similar to how we handle images. I wouldn't support the ability to customize template.html for this use case. I'd be happy to add support for og:video to the plugin itself though.

I think that generator meta tag should be optional (or at least doesn't show version).

Covered by #404

automatically generate image and video urls based on id stored on front-matter

This also sounds like a separate feature request, and I'd support seeing a separate issue with more information about what you're after in that regard. I don't currently see how this sort of customization would be useful.

reuse social links that are stored in another config key

I don't see a reason to provide support for customizing template.html for this either. Plugins need to be isolated and stand alone. Duplication is annoying, yes, but having a concrete well defined way of knowing how things get mapped from config into the tag is better than removing duplication in this case, IMO.

@mattr- mattr- closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2022
@jekyll jekyll locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants