Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Node 12 #117

Open
BryanHunt opened this issue May 29, 2019 · 6 comments
Open

Build fails on Node 12 #117

BryanHunt opened this issue May 29, 2019 · 6 comments

Comments

@BryanHunt
Copy link

This code fails to build when using Node 12. I tried forking the code and doing a simple update on the nan version, but the build still fails.

@jeremycx
Copy link
Owner

I haven't updated to 12 yet myself, so any work/research is appreciated...

@jjhoughton
Copy link

You can try this if you like https://github.com/jjhoughton/napi-ldap it hasn't seen a great deal of widespread use yet.

@jjhoughton
Copy link

Would you consider taking my changes @jeremycx if i open a pr? It's kind a rewrite though using n-api and c instead of c++.

@jjhoughton
Copy link

jjhoughton commented Aug 17, 2020

fixed here #120

@celevra
Copy link

celevra commented Aug 28, 2024

it also fails on v18 ;-)
tried jjhoughton's respository but same error.
i can't find an other ldap client library for node.js
any chances to get this to work again?

@jjhoughton
Copy link

For my repo https://github.com/jjhoughton/napi-ldap you can try install these two system packages openldap-devel cyrus-sasl-devel and then set this environment variable when running npm install USE_SYSTEM_LDAP=1 npm i, that'll make it link to the system libraries. If you're using arm you'll have problems getting it to build if you don't do that. it's hard to know why it didn't compile without a stack trace. I'm currently using my repo on node 20 so it should work on node 18 given i know it also works on node 12 and node 16.

I did also make this change to get this repo working on node12 although I suspect you'd have to do further work to get it working with node18.

#120

i can't find an other ldap client library for node.js

There was this one which looked pretty good but it looks like it's been decommissioned which is a shame https://www.npmjs.com/package/ldapjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants