From 57211f4e7fa72ca70d47b499d7d75fa6ad75020a Mon Sep 17 00:00:00 2001 From: delarea Date: Wed, 25 Dec 2024 22:22:36 +0200 Subject: [PATCH 01/25] test --- pip_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pip_test.go b/pip_test.go index c4199eded..71567636f 100644 --- a/pip_test.go +++ b/pip_test.go @@ -144,7 +144,7 @@ func assertDependenciesRequestedByAndChecksums(t *testing.T, module buildinfo.Mo switch dependency.Id { case "pyyaml:5.1.2", "nltk:3.4.5", "macholib:1.11": assert.EqualValues(t, [][]string{{moduleName}}, dependency.RequestedBy) - case "six:1.16.0": + case "six:1.17.0": assert.EqualValues(t, [][]string{{"nltk:3.4.5", moduleName}}, dependency.RequestedBy) default: // Altgraph version can change From aec14995333976a6f84d5dac4b4996bce26b04b6 Mon Sep 17 00:00:00 2001 From: delarea Date: Thu, 26 Dec 2024 09:42:09 +0200 Subject: [PATCH 02/25] Add env for ubuntu --- .github/workflows/nugetTests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 98ca0e586..c17b67efa 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -48,6 +48,9 @@ jobs: - name: Install .NET uses: actions/setup-dotnet@v4 + if: matrix.os == 'ubuntu' + env: + DOTNET_INSTALL_DIR: "path/to/directory" with: dotnet-version: '6.x' From f363462ba8649aa3295104822c87586a426ef1a3 Mon Sep 17 00:00:00 2001 From: delarea Date: Thu, 26 Dec 2024 10:02:34 +0200 Subject: [PATCH 03/25] Add env DOTNET_INSTALL_DIR --- .github/workflows/nugetTests.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index c17b67efa..3633a83b5 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -10,6 +10,10 @@ on: pull_request_target: types: [ labeled ] +# Sets dotnet installation dir to avoid permissions issues while installing. +env: + DOTNET_INSTALL_DIR: "./.dotnet" + # Ensures that only the latest commit is running for each PR at a time. concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }} @@ -48,9 +52,6 @@ jobs: - name: Install .NET uses: actions/setup-dotnet@v4 - if: matrix.os == 'ubuntu' - env: - DOTNET_INSTALL_DIR: "path/to/directory" with: dotnet-version: '6.x' From 8a7ec0617369fac32844a8b936962104b5003eb0 Mon Sep 17 00:00:00 2001 From: delarea Date: Thu, 26 Dec 2024 10:25:01 +0200 Subject: [PATCH 04/25] trigger From df6c27df93c5c7d209565ca530ad06782560c8d6 Mon Sep 17 00:00:00 2001 From: delarea Date: Thu, 26 Dec 2024 11:48:24 +0200 Subject: [PATCH 05/25] test without --- .github/workflows/nugetTests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 3633a83b5..1c0ec8200 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -10,9 +10,9 @@ on: pull_request_target: types: [ labeled ] -# Sets dotnet installation dir to avoid permissions issues while installing. -env: - DOTNET_INSTALL_DIR: "./.dotnet" +## Sets dotnet installation dir to avoid permissions issues while installing. +#env: +# DOTNET_INSTALL_DIR: "./.dotnet" # Ensures that only the latest commit is running for each PR at a time. concurrency: From c9d897b2ab11a10ac516dee9726f6bcdabbe9d93 Mon Sep 17 00:00:00 2001 From: delarea Date: Thu, 26 Dec 2024 17:12:04 +0200 Subject: [PATCH 06/25] Test Fix nugetTests.yml --- .github/workflows/nugetTests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 1c0ec8200..b8484a149 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -11,8 +11,8 @@ on: types: [ labeled ] ## Sets dotnet installation dir to avoid permissions issues while installing. -#env: -# DOTNET_INSTALL_DIR: "./.dotnet" +env: + DOTNET_INSTALL_DIR: "./.dotnet" # Ensures that only the latest commit is running for each PR at a time. concurrency: From 990d20f01af79d6f96d87e18de042374a3782698 Mon Sep 17 00:00:00 2001 From: delarea Date: Sun, 29 Dec 2024 14:09:08 +0200 Subject: [PATCH 07/25] Install .NET before NuGet --- .github/workflows/nugetTests.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index b8484a149..0c4837744 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -45,16 +45,16 @@ jobs: sudo apt-get update sudo apt-get install -y mono-complete - - name: Install NuGet - uses: nuget/setup-nuget@v2 - with: - nuget-version: '6.x' - - name: Install .NET uses: actions/setup-dotnet@v4 with: dotnet-version: '6.x' + - name: Install NuGet + uses: nuget/setup-nuget@v2 + with: + nuget-version: '6.x' + - name: Setup Go with cache uses: jfrog/.github/actions/install-go-with-cache@main From e29bef75255fe1e12db1ef76e08eb05766dfb3ca Mon Sep 17 00:00:00 2001 From: delarea Date: Sun, 29 Dec 2024 14:26:22 +0200 Subject: [PATCH 08/25] Remove .NET env var --- .github/workflows/nugetTests.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 0c4837744..d71fdf0ab 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -10,10 +10,6 @@ on: pull_request_target: types: [ labeled ] -## Sets dotnet installation dir to avoid permissions issues while installing. -env: - DOTNET_INSTALL_DIR: "./.dotnet" - # Ensures that only the latest commit is running for each PR at a time. concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }} From f50d3def1ace7d44ed8dca7a82364bda11688e49 Mon Sep 17 00:00:00 2001 From: delarea Date: Sun, 29 Dec 2024 15:05:31 +0200 Subject: [PATCH 09/25] Add comments --- pip_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pip_test.go b/pip_test.go index 71567636f..4a5f16555 100644 --- a/pip_test.go +++ b/pip_test.go @@ -141,6 +141,8 @@ func testPipCmd(t *testing.T, projectPath, buildNumber, module string, expectedD func assertDependenciesRequestedByAndChecksums(t *testing.T, module buildinfo.Module, moduleName string) { for _, dependency := range module.Dependencies { assertDependencyChecksums(t, dependency.Checksum) + // Note that the versions of dependencies may vary, + // as they are requested by the main module, which could update their sub-dependencies. switch dependency.Id { case "pyyaml:5.1.2", "nltk:3.4.5", "macholib:1.11": assert.EqualValues(t, [][]string{{moduleName}}, dependency.RequestedBy) From a3aa044cde1ebb11711bfa381cc55b9a6a44abde Mon Sep 17 00:00:00 2001 From: delarea Date: Sun, 29 Dec 2024 15:08:08 +0200 Subject: [PATCH 10/25] Update the oldest version of mac-os from 12 to 13 --- .github/workflows/scriptTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/scriptTests.yml b/.github/workflows/scriptTests.yml index 916d25562..835783b3c 100644 --- a/.github/workflows/scriptTests.yml +++ b/.github/workflows/scriptTests.yml @@ -26,7 +26,7 @@ jobs: - os: "macos-latest" - - os: "macos-12" + - os: "macos-13" - os: "windows-latest" osSuffix: ".exe" From b3f4ce213c3252356db0ea883afe0e1f4371f962 Mon Sep 17 00:00:00 2001 From: delarea Date: Sun, 29 Dec 2024 16:53:08 +0200 Subject: [PATCH 11/25] Change the image for artifactory 6 --- .github/workflows/transferTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/transferTests.yml b/.github/workflows/transferTests.yml index 9e061137c..f5451eb5e 100644 --- a/.github/workflows/transferTests.yml +++ b/.github/workflows/transferTests.yml @@ -42,7 +42,7 @@ jobs: Transfer-Artifactory-6-Tests: if: contains(github.event.pull_request.labels.*.name, 'safe to test') || github.event_name == 'push' name: artifactory-6 - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - name: Checkout code uses: actions/checkout@v4 From d993e9e607a21bb7bdabda3efa710e82da3e6b1e Mon Sep 17 00:00:00 2001 From: delarea Date: Sun, 29 Dec 2024 16:57:48 +0200 Subject: [PATCH 12/25] Add comment --- .github/workflows/transferTests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/transferTests.yml b/.github/workflows/transferTests.yml index f5451eb5e..f61f3b2a7 100644 --- a/.github/workflows/transferTests.yml +++ b/.github/workflows/transferTests.yml @@ -42,6 +42,7 @@ jobs: Transfer-Artifactory-6-Tests: if: contains(github.event.pull_request.labels.*.name, 'safe to test') || github.event_name == 'push' name: artifactory-6 + # Fixed runner image to set the java tools needed for artifactory 6 runs-on: ubuntu-20.04 steps: - name: Checkout code From 7411975a13673cd169bbbe274c1cfd71a91eac44 Mon Sep 17 00:00:00 2001 From: Eyal Delarea Date: Mon, 30 Dec 2024 10:08:38 +0200 Subject: [PATCH 13/25] Update pip_test.go Co-authored-by: Michael Sverdlov --- pip_test.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pip_test.go b/pip_test.go index 4a5f16555..43a583f67 100644 --- a/pip_test.go +++ b/pip_test.go @@ -141,8 +141,7 @@ func testPipCmd(t *testing.T, projectPath, buildNumber, module string, expectedD func assertDependenciesRequestedByAndChecksums(t *testing.T, module buildinfo.Module, moduleName string) { for _, dependency := range module.Dependencies { assertDependencyChecksums(t, dependency.Checksum) - // Note that the versions of dependencies may vary, - // as they are requested by the main module, which could update their sub-dependencies. + // Note: Sub-dependency versions may vary because root dependencies can specify version ranges (e.g., >=1.0.0) for their sub-dependencies. switch dependency.Id { case "pyyaml:5.1.2", "nltk:3.4.5", "macholib:1.11": assert.EqualValues(t, [][]string{{moduleName}}, dependency.RequestedBy) From 197a15ab4d87e1cdea01502bd391d418127caf23 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 10:52:16 +0200 Subject: [PATCH 14/25] test nuget version --- .github/workflows/nugetTests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index d71fdf0ab..b001a7e30 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -43,8 +43,6 @@ jobs: - name: Install .NET uses: actions/setup-dotnet@v4 - with: - dotnet-version: '6.x' - name: Install NuGet uses: nuget/setup-nuget@v2 From b14ef47fcb5649a9d6bf24ce8baf25efdc9c74a8 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 10:56:44 +0200 Subject: [PATCH 15/25] version 8 --- .github/workflows/nugetTests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index b001a7e30..1cd59c07a 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -43,6 +43,8 @@ jobs: - name: Install .NET uses: actions/setup-dotnet@v4 + with: + dotnet-version: '8.x' - name: Install NuGet uses: nuget/setup-nuget@v2 From 4a4afff3f1824022c05c7081205b6499e68f3272 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 10:58:46 +0200 Subject: [PATCH 16/25] version 6 --- .github/workflows/nugetTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 1cd59c07a..d71fdf0ab 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -44,7 +44,7 @@ jobs: - name: Install .NET uses: actions/setup-dotnet@v4 with: - dotnet-version: '8.x' + dotnet-version: '6.x' - name: Install NuGet uses: nuget/setup-nuget@v2 From ae6b4c5e7f286580419f18ba9cbc6e2f08497cb7 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 11:12:55 +0200 Subject: [PATCH 17/25] test --- .github/workflows/nugetTests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index d71fdf0ab..5415f6bdb 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -15,6 +15,9 @@ concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }} cancel-in-progress: true +env: + DOTNET_INSTALL_DIR: "/usr/share/dotnet" + jobs: NuGet-Tests: if: contains(github.event.pull_request.labels.*.name, 'safe to test') || github.event_name == 'push' From 1e10beb0fa457f8f9eb2e6331e23a8f6272ff839 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 11:17:07 +0200 Subject: [PATCH 18/25] only set env for ubuntu --- .github/workflows/nugetTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 5415f6bdb..7e04556e7 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -16,7 +16,7 @@ concurrency: cancel-in-progress: true env: - DOTNET_INSTALL_DIR: "/usr/share/dotnet" + DOTNET_INSTALL_DIR: ${{ matrix.os == 'ubuntu' && '/usr/share/dotnet' || '' }} jobs: NuGet-Tests: From 7c6010980f8a46f736fdd7ebca8afe66cbee676e Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 11:21:20 +0200 Subject: [PATCH 19/25] test --- .github/workflows/nugetTests.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 7e04556e7..966b8fcfb 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -15,9 +15,6 @@ concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }} cancel-in-progress: true -env: - DOTNET_INSTALL_DIR: ${{ matrix.os == 'ubuntu' && '/usr/share/dotnet' || '' }} - jobs: NuGet-Tests: if: contains(github.event.pull_request.labels.*.name, 'safe to test') || github.event_name == 'push' @@ -43,6 +40,7 @@ jobs: echo "deb https://download.mono-project.com/repo/ubuntu stable-focal main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list sudo apt-get update sudo apt-get install -y mono-complete + export DOTNET_INSTALL_DIR="/usr/share/dotnet" - name: Install .NET uses: actions/setup-dotnet@v4 From 53b0a67be77314dfca395fa4da69b5aeccef849d Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 11:23:45 +0200 Subject: [PATCH 20/25] test2 --- .github/workflows/nugetTests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 966b8fcfb..a3e4697b3 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -40,10 +40,12 @@ jobs: echo "deb https://download.mono-project.com/repo/ubuntu stable-focal main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list sudo apt-get update sudo apt-get install -y mono-complete - export DOTNET_INSTALL_DIR="/usr/share/dotnet" - name: Install .NET uses: actions/setup-dotnet@v4 + if: matrix.os == 'ubuntu' + env: + DOTNET_INSTALL_DIR: "/usr/share/dotnet" with: dotnet-version: '6.x' From 097d12621b6e359b9cd08f36216018414b88d671 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 12:09:18 +0200 Subject: [PATCH 21/25] Test --- .github/workflows/nugetTests.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index a3e4697b3..c6034c5d7 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -30,22 +30,23 @@ jobs: with: ref: ${{ github.event.pull_request.head.sha }} - # Install Mono on Ubuntu to run nuget.exe - - name: Install Mono on Ubuntu + # Ubuntu agents require Mono to run nuget.exe, and to set permissions for the dotnet home directory + - name: Prepare Ubuntu agent if: matrix.os == 'ubuntu' run: | + # Install Mono sudo apt-get update sudo apt-get install -y apt-transport-https dirmngr gnupg ca-certificates sudo apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF echo "deb https://download.mono-project.com/repo/ubuntu stable-focal main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list sudo apt-get update sudo apt-get install -y mono-complete + # Set permissions for the dotnet home directory + sudo mkdir /usr/share/dotnet + sudo chmod 777 /usr/share/dotnet - name: Install .NET uses: actions/setup-dotnet@v4 - if: matrix.os == 'ubuntu' - env: - DOTNET_INSTALL_DIR: "/usr/share/dotnet" with: dotnet-version: '6.x' From 4ed95f5bd164acfae892199c1e014f9d28dc72d0 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 12:12:33 +0200 Subject: [PATCH 22/25] Don't fail if dir already exists --- .github/workflows/nugetTests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index c6034c5d7..5c732f593 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -30,7 +30,9 @@ jobs: with: ref: ${{ github.event.pull_request.head.sha }} - # Ubuntu agents require Mono to run nuget.exe, and to set permissions for the dotnet home directory + # Ubuntu agents require Mono to run nuget.exe. + # Also, there is an issue with the .NET setup action that requires setting permissions for the dotnet home directory. + # Therefore, we manually set permissions until the issue is resolved. (https://github.com/actions/setup-dotnet/issues/565) - name: Prepare Ubuntu agent if: matrix.os == 'ubuntu' run: | @@ -42,7 +44,7 @@ jobs: sudo apt-get update sudo apt-get install -y mono-complete # Set permissions for the dotnet home directory - sudo mkdir /usr/share/dotnet + sudo mkdir -p /usr/share/dotnet sudo chmod 777 /usr/share/dotnet - name: Install .NET From 9a4fb10fc7b8339ef637ffe9e3a56286471024cf Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 12:54:15 +0200 Subject: [PATCH 23/25] Test workaround --- .github/workflows/nugetTests.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 5c732f593..f56dcfe01 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -30,20 +30,18 @@ jobs: with: ref: ${{ github.event.pull_request.head.sha }} - # Ubuntu agents require Mono to run nuget.exe. - # Also, there is an issue with the .NET setup action that requires setting permissions for the dotnet home directory. - # Therefore, we manually set permissions until the issue is resolved. (https://github.com/actions/setup-dotnet/issues/565) - - name: Prepare Ubuntu agent + # Install Mono on Ubuntu to run nuget.exe + - name: Install Mono on Ubuntu if: matrix.os == 'ubuntu' run: | - # Install Mono sudo apt-get update sudo apt-get install -y apt-transport-https dirmngr gnupg ca-certificates sudo apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF echo "deb https://download.mono-project.com/repo/ubuntu stable-focal main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list sudo apt-get update sudo apt-get install -y mono-complete - # Set permissions for the dotnet home directory + # Fixes https://github.com/actions/setup-dotnet/issues/554 + echo "DOTNET_INSTALL_DIR="/usr/share/dotnet" >> $GITHUB_ENV sudo mkdir -p /usr/share/dotnet sudo chmod 777 /usr/share/dotnet From 4c570fa2404105bbed295b80e78a630cf478336e Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 12:55:30 +0200 Subject: [PATCH 24/25] Fix syntax --- .github/workflows/nugetTests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index f56dcfe01..6d21fcbe8 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -41,7 +41,7 @@ jobs: sudo apt-get update sudo apt-get install -y mono-complete # Fixes https://github.com/actions/setup-dotnet/issues/554 - echo "DOTNET_INSTALL_DIR="/usr/share/dotnet" >> $GITHUB_ENV + echo "DOTNET_INSTALL_DIR=/usr/share/dotnet" >> $GITHUB_ENV sudo mkdir -p /usr/share/dotnet sudo chmod 777 /usr/share/dotnet From 73c13f9538e2831663fcc9b3961e3f973d9d76b1 Mon Sep 17 00:00:00 2001 From: delarea Date: Mon, 30 Dec 2024 13:23:06 +0200 Subject: [PATCH 25/25] Comments --- .github/workflows/nugetTests.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nugetTests.yml b/.github/workflows/nugetTests.yml index 6d21fcbe8..688465904 100644 --- a/.github/workflows/nugetTests.yml +++ b/.github/workflows/nugetTests.yml @@ -30,17 +30,18 @@ jobs: with: ref: ${{ github.event.pull_request.head.sha }} - # Install Mono on Ubuntu to run nuget.exe - - name: Install Mono on Ubuntu + # Prepare ubuntu by installing Mono and handle dotnet installation issues. + - name: Prepare ubuntu if: matrix.os == 'ubuntu' run: | + # Install Mono sudo apt-get update sudo apt-get install -y apt-transport-https dirmngr gnupg ca-certificates sudo apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF echo "deb https://download.mono-project.com/repo/ubuntu stable-focal main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list sudo apt-get update sudo apt-get install -y mono-complete - # Fixes https://github.com/actions/setup-dotnet/issues/554 + # Fixes dotnet installation issues, see https://github.com/jfrog/jfrog-cli/pull/2808 for more details. echo "DOTNET_INSTALL_DIR=/usr/share/dotnet" >> $GITHUB_ENV sudo mkdir -p /usr/share/dotnet sudo chmod 777 /usr/share/dotnet