fix: proper error handling

Author: jghauser

lua/papis/completion/init.lua

@@ -7,17 +7,16 @@
 
 local log = require("papis.log")
 
-local has_cmp, cmp = pcall(require, "cmp")
-if not has_cmp then
-  log.error("The plugin nvim-cmp wasn't found but the respective papis.nvim module is configured to be loaded.")
-  return nil
-end
-
 local M = {}
 
 ---Sets up the papis.nvim cmp completion source
 function M.setup()
   log.debug("Cmp: setting up module")
+  local has_cmp, cmp = pcall(require, "cmp")
+  if not has_cmp then
+    error("The plugin nvim-cmp wasn't found but the respective papis.nvim module is configured to be loaded.")
+  end
+
   require("papis.completion.data").init()
   cmp.register_source("papis", require("papis.completion.source").new())
 end

lua/papis/init.lua

@@ -63,8 +63,7 @@ function M.start()
   -- set up db
   local db = require("papis.sqlite-wrapper")
   if not db then
-    log.error("Requiring `sqlite-wrapper.lua` failed. Aborting...")
-    return nil
+    error("Requiring `sqlite-wrapper.lua` failed. Aborting...")
   end
   db:init()
 
@@ -76,8 +75,7 @@ function M.start()
   -- require what's necessary within `M.start()` instead of globally to allow lazy-loading
   local data = require("papis.data")
   if not data then
-    log.error("Requiring `data.lua` failed. Aborting...")
-    return nil
+    error("Requiring `data.lua` failed. Aborting...")
   end
 
   -- setup commands

lua/papis/search/init.lua

@@ -5,12 +5,6 @@
 --
 
 local log = require("papis.log")
-local has_telescope, telescope = pcall(require, "telescope")
-if not has_telescope then
-  log.error("The plugin telescope.nvim wasn't found but the search module is enabled and requires it.")
-  return nil
-end
-local entry_display = require("telescope.pickers.entry_display")
 local config = require("papis.config")
 local commands = require("papis.commands")
 local keymaps = require("papis.keymaps")
@@ -20,8 +14,6 @@ if not db then
 end
 
 local papis_entry_display = {}
-setmetatable(papis_entry_display, { __index = entry_display })
-papis_entry_display.truncate = function(a) return a end -- HACK: there must better way to turn this off
 
 local telescope_precalc = {}
 local precalc_last_updated = 0
@@ -106,6 +98,15 @@ end
 ---Sets up the papis.nvim telescope extension
 function M.setup()
   log.debug("Search: setting up module")
+  local has_telescope, telescope = pcall(require, "telescope")
+  if not has_telescope then
+    error("The plugin telescope.nvim wasn't found but the search module is enabled and requires it.")
+  end
+
+  local entry_display = require("telescope.pickers.entry_display")
+  setmetatable(papis_entry_display, { __index = entry_display })
+  papis_entry_display.truncate = function(a) return a end -- HACK: there must better way to turn this off
+
   require("papis.search.data").init()
   telescope.setup({
     extensions = {

lua/papis/sqlite-wrapper.lua

@@ -9,8 +9,7 @@ local log = require("papis.log")
 
 local has_sqlite, sqlite = pcall(require, "sqlite")
 if not has_sqlite then
-  log.error("The dependency 'sqlite.nvim' is missing. Ensure that it is installed to run papis.nvim")
-  return nil
+  error("The dependency 'sqlite.nvim' is missing. Ensure that it is installed to run papis.nvim")
 end
 local sqlite_utils = require "sqlite.utils"
 

lua/papis/utils.lua

@@ -127,8 +127,7 @@ end
 function M:do_open_text_file(papis_id, type)
   local db = require("papis.sqlite-wrapper")
   if not db then
-    log.error("Sqlite-wrapper has not been initialised properly. Aborting...")
-    return nil
+    error("Sqlite-wrapper has not been initialised properly. Aborting...")
   end
   log.debug("Opening a text file")
   local entry = db.data:get({ papis_id = papis_id }, { "notes", "id" })[1]