Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Blenheim Spaniel" (and others): Incorrect breed name and missing variants #151

Open
monsieurbaguette opened this issue Jan 19, 2021 · 1 comment

Comments

@monsieurbaguette
Copy link

monsieurbaguette commented Jan 19, 2021

The correct name for the breed labeled as Blenheim Spaniels in the API is Cavalier King Charles Spaniel. Given that this wouldn't conform to the breed-subbreed standard, it would be a suitable name if there weren't multiple variants of the Cavalier King Charles Spaniel.

The variants are:

Ruby
image

Tri-color
image

Blenheim
image

Black and Tan
image

A similar issue is present with the golden retriever, but the coat variations in goldens generally don't count as a "type" of that breed. The main issue with the Cavaliers is that the breed name in the API is a variant of the breed, and it only encompasses a quarter of the breed. Additionally, there are some minor issues (e.g. Shiba Inu being shortened to Shiba, as well as other odd directory names for breeds) that make developing consumer-friendly applications using this API unnecessarily tedious (it isn't bad to the point where using the API is impractical, but improving it would definitely help myself and others quite a bit when using the API).

@jigsawpieces
Copy link
Owner

Hi @monsieurbaguette, if you'd like to suggest a better method for folder organisation feel free to submit a PR and we can review 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants