Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to make things more modular #56

Open
jonathontoon opened this issue Jan 9, 2020 · 3 comments
Open

Refactor code to make things more modular #56

jonathontoon opened this issue Jan 9, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jonathontoon
Copy link
Owner

Expected Behavior

Make things easier to read and follow

Current Behavior

A single file performs well but is hard to parse.

@jonathontoon jonathontoon added the enhancement New feature or request label Jan 9, 2020
@ibrahimbutt
Copy link

ibrahimbutt commented Jan 17, 2020

@jonathontoon have you considered using TypeScript? It could help in making things more modular, as it allows for better OOP, if you choose to go the OOP route that is.

Besides that, have you considered testing? I would be happy to help in that regard, and thereon with refactoring.

@jonathontoon
Copy link
Owner Author

jonathontoon commented Jan 19, 2020

@ibrahimbutt I think Typescript, while I personally like aspects of it would close off a lot of people with only fundamental Javascript knowledge who might have been able to contribute otherwise.

Testing should come a long at some point. As I'm mapping out what Manifest 2.0 might look like I think it should be considered at the start. I've personally only ever used basic snapshot testing for React components and Jest for Redux. Where might be a good place to start test-wise with vanilla Javascript?

@ankitatechie
Copy link

@jonathontoon I think there is a great scope in CSS improvements as well. Right now selectors are tightly coupled to a specific HTML structure along with deep level nesting.

If you prefer, I can fix it up for you. Also, I can help you with making it more presentable with minimal code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants