Skip to content

Commit 0d7246c

Browse files
author
rkennke
committed
8251354: Shenandoah: Fix jdk/jfr/tool/TestPrintJSON.java test failure
Reviewed-by: clanger, stuefe
1 parent a9fc44e commit 0d7246c

File tree

2 files changed

+12
-20
lines changed

2 files changed

+12
-20
lines changed

make/hotspot/gensrc/GensrcJfr.gmk

+3-7
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,11 @@ JFR_SRCDIR := $(TOPDIR)/src/hotspot/share/jfr/metadata
5757
METADATA_XML := $(JFR_SRCDIR)/metadata.xml
5858
METADATA_XSD := $(JFR_SRCDIR)/metadata.xsd
5959

60-
ifeq ($(call check-jvm-feature, shenandoahgc), true)
61-
METADATA_SHENANDOAH_XML := $(JFR_SRCDIR)/metadata-shenandoah.xml
62-
endif
63-
64-
$(JFR_OUTPUTDIR)/jfrEventClasses.hpp: $(METADATA_XSD) \
65-
$(BUILD_JFR_TOOLS) $(METADATA_XML) $(METADATA_SHENANDOAH_XML)
60+
$(JFR_OUTPUTDIR)/jfrEventClasses.hpp: $(METADATA_XML) $(METADATA_XSD) \
61+
$(BUILD_JFR_TOOLS)
6662
$(call LogInfo, Generating $(@F))
6763
$(call MakeDir, $(@D))
68-
$(call ExecuteWithLog, $@, $(TOOL_JFR_GEN) $(METADATA_XSD) $(JFR_OUTPUTDIR) $(METADATA_XML) $(METADATA_SHENANDOAH_XML) )
64+
$(call ExecuteWithLog, $@, $(TOOL_JFR_GEN) $(METADATA_XML) $(METADATA_XSD) $(JFR_OUTPUTDIR))
6965
test -f $@
7066

7167
TARGETS += $(JFR_OUTPUTDIR)/jfrEventClasses.hpp

make/src/classes/build/tools/jfr/GenerateJfrFiles.java

+9-13
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,18 @@
2828
public class GenerateJfrFiles {
2929

3030
public static void main(String... args) throws Exception {
31-
if (args.length < 3) {
31+
if (args.length != 3) {
3232
System.err.println("Incorrect number of command line arguments.");
3333
System.err.println("Usage:");
34-
System.err.println("java GenerateJfrFiles[.java] <path-to-metadata.xsd> <output-directory> <path-to-metadata.xml> [<path-to-metadata.xml> ...]");
34+
System.err.println("java GenerateJfrFiles[.java] <path-to-metadata.xml> <path-to-metadata.xsd> <output-directory>");
3535
System.exit(1);
3636
}
3737
try {
38-
File metadataSchema = new File(args[0]);
39-
File outputDirectory = new File(args[1]);
40-
File[] metadataXml = new File[args.length - 2];
41-
for (int i = 2; i < args.length; i++) {
42-
metadataXml[i - 2] = new File(args[i]);
43-
}
44-
Metadata metadata = new Metadata(metadataSchema, metadataXml);
38+
File metadataXml = new File(args[0]);
39+
File metadataSchema = new File(args[1]);
40+
File outputDirectory = new File(args[2]);
41+
42+
Metadata metadata = new Metadata(metadataXml, metadataSchema);
4543
metadata.verify();
4644
metadata.wireUpTypes();
4745

@@ -77,14 +75,12 @@ static class TypeElement {
7775
static class Metadata {
7876
final Map<String, TypeElement> types = new LinkedHashMap<>();
7977
final Map<String, XmlType> xmlTypes = new HashMap<>();
80-
Metadata(File metadataSchema, File[] metadataXml) throws ParserConfigurationException, SAXException, FileNotFoundException, IOException {
78+
Metadata(File metadataXml, File metadataSchema) throws ParserConfigurationException, SAXException, FileNotFoundException, IOException {
8179
SchemaFactory schemaFactory = SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
8280
SAXParserFactory factory = SAXParserFactory.newInstance();
8381
factory.setSchema(schemaFactory.newSchema(metadataSchema));
8482
SAXParser sp = factory.newSAXParser();
85-
for (File file : metadataXml) {
86-
sp.parse(file, new MetadataHandler(this));
87-
}
83+
sp.parse(metadataXml, new MetadataHandler(this));
8884
}
8985

9086
List<EventElement> getEvents() {

0 commit comments

Comments
 (0)