Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommendation - Improve Naming #24

Open
IAmPara0x opened this issue Dec 15, 2022 · 0 comments
Open

Recommendation - Improve Naming #24

IAmPara0x opened this issue Dec 15, 2022 · 0 comments
Labels
audit recommendation

Comments

@IAmPara0x
Copy link

IAmPara0x commented Dec 15, 2022 •
edited by cstml
Loading

Severity CVSS Vulnerability type
None 0.0 incorrect-documentation

Description

Vesting contract uses Action type as it's redeemer, this type has a single data constructor which is named Disburse whose type is Disbure :: [PubKeyHash] -> Action. We think that this name is misleading as the role of this redeemer is not only to disburse the value locked in the contract when the deadline has passed but also to update the current beneficiaries of the Input datum. Hence, we think the option of updating beneficiaries should also be highlighted in the name of Action type's data constructor.
@cstml cstml changed the title Better naming of Disburse the data constructor of Action type. Improve Naming Dec 15, 2022
@cstml cstml changed the title Improve Naming Recommendation - Improve Naming Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit recommendation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cstml @IAmPara0x