-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add search results provided by google #10
Comments
I think that'd be awesome, I'm just not sure how to do it without really complicating the module. As you're right, Google provides a lot useful answers to questions posed in natural language. But how do you reliably in a non-hacky manner parse results to "what is 2+2", "what time is it in Australia", "define: someword"? I'm not sure that you can. So, it may be best to leave those sorts of queries to the official API. Thoughts? |
I didn't try all of the queries, but I guess there is some certain pattern of it (so far I tested
I'm happy to send PR, if you don't have much time to test this. |
+1 ! Instead of Other things you could expose on this object:
I think this would simplify the API and make it more extensible without breaking compatibility. Of course this one change isn't backwards compatible and would require a major version bump. If you don't want to implement this scraping, I think you should at least change the response to an object like I describe and provide the cheerio object in it to allow custom scraping. |
#38 proposes a response object, the scrapped result on this issue could be added to it. I actually need it, I can do it on my side once cheerio is exposed but I could add it to this module just as well |
when you google something about date, time, currency, weather, google will provide the answer for you, like
'what time is it?'
'usd eur'
what do you think about adding this kind of results?
The text was updated successfully, but these errors were encountered: