Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor release for improved warnings and fixes #254

Closed
Krinkle opened this issue Mar 20, 2017 · 7 comments
Closed

Minor release for improved warnings and fixes #254

Krinkle opened this issue Mar 20, 2017 · 7 comments

Comments

@Krinkle
Copy link
Member

Krinkle commented Mar 20, 2017

Would be nice if a new minor release could be cut so that the improved warnings from dc1d703 (#204) goes out.


The minor release from current master would contain:

@dmethvin
Copy link
Member

Yeah, a 3.2 release seems like a good idea. See #220 for why isArray isn't being warned. It's a major pain to do those warnings when there are internal uses inside jQuery itself. The positional selectors one would be really annoying since they're frequently used and I'm not sure we're ever going to remove them.

@mgol
Copy link
Member

mgol commented Mar 20, 2017

I think we should warn only in jQuery 3.2.0+ then, better than nothing!

@Krinkle
Copy link
Member Author

Krinkle commented Mar 20, 2017

From #246 (comment)

@dmethvin wrote:
Right but in general we have said that jQuery Migrate 3.x works with jQuery 3.x. If you used an older jQuery than 3.2 it would be throwing warnings frequently. Is that considered okay? In the past we tried to avoid that.

It also complicates our test matrix since we couldn't test Migrate 3.2 with a jQuery older than 3.2 and assert no warnings.

@Krinkle wrote:
@dmethvin No, I agree 3.x/3.x compat should be kept. It's our responsibility to keep that flexibility supported to reduce user confusion and upgrade smoothness. If we do want to add the warnings before Migrate 4, it would have to involve a version check.
Personally, I the complexity of a version check is worth it. The earlier the better. It would give platforms like WordPress and MediaWiki the opportunity to warn about these methods much earlier to end-users; instead of only after jQuery 4 is released.
The more users we (indirectly) enable to comfortably migrate early, the better our position is to change things in the jQuery 4 API for the benefit of everyone.

@Krinkle Krinkle changed the title Minor release for improved warnings Minor release for improved warnings fixes Aug 19, 2017
@Krinkle
Copy link
Member Author

Krinkle commented Aug 19, 2017

@dmethvin Added a release note draft to the start comment.
Is there anything still blocking a minor release?

@Krinkle Krinkle changed the title Minor release for improved warnings fixes Minor release for improved warnings and fixes Aug 22, 2017
@dmethvin
Copy link
Member

Sorry @Krinkle, I'm not sure exactly what needs to be done at the moment. I need a day to go through and see where things stand. If we're going to catch all the jQuery 3.2.0 deprecations I think there are a few things left and some may not have issues yet, but that would be part of the review.

@Krinkle
Copy link
Member Author

Krinkle commented Aug 23, 2017

@dmethvin If we can get all jQuery 3.2.0 additions finalised soon, that'd be great. But if not, could we consider not blocking on that, and perhaps have a release with a 3.0.x or 3.1.x version number first, to get these fixes released soon?

@dmethvin
Copy link
Member

SGTM, we can do another release later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants