-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor release for improved warnings and fixes #254
Comments
Yeah, a 3.2 release seems like a good idea. See #220 for why isArray isn't being warned. It's a major pain to do those warnings when there are internal uses inside jQuery itself. The positional selectors one would be really annoying since they're frequently used and I'm not sure we're ever going to remove them. |
I think we should warn only in jQuery 3.2.0+ then, better than nothing! |
From #246 (comment)
|
@dmethvin Added a release note draft to the start comment. |
Sorry @Krinkle, I'm not sure exactly what needs to be done at the moment. I need a day to go through and see where things stand. If we're going to catch all the jQuery 3.2.0 deprecations I think there are a few things left and some may not have issues yet, but that would be part of the review. |
@dmethvin If we can get all jQuery 3.2.0 additions finalised soon, that'd be great. But if not, could we consider not blocking on that, and perhaps have a release with a 3.0.x or 3.1.x version number first, to get these fixes released soon? |
SGTM, we can do another release later. |
Would be nice if a new minor release could be cut so that the improved warnings from dc1d703 (#204) goes out.
The minor release from current master would contain:
jQuery.holdReady()
. Core: Warn on use of jQuery.holdReady() #247.apply()
onconsole.log
to satisfy IE9. Core: Don't use .apply() on console.log to satisfy IE9 #241jQuery.fx.interval
. Effects: Warn and fill jQuery.fx.interval #216jQuery.event.props.concat
for jQuery Mobile pre-1.5. Event: Detect jQuery Mobile pre-1.5 use of jQuery.event.props.concat #209$(window).on("load"...)
. Event: Warn about late use of $(window).on("load"...) #217The text was updated successfully, but these errors were encountered: