Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings.md missing docs for a few warnings #443

Closed
Tiberriver256 opened this issue Oct 16, 2021 · 2 comments · Fixed by #447
Closed

Warnings.md missing docs for a few warnings #443

Tiberriver256 opened this issue Oct 16, 2021 · 2 comments · Fixed by #447
Assignees
@mgol
Milestone
3.4.0

Comments

@Tiberriver256
Copy link

I received the following warnings but was unable to find recommended fixes within the warnings.md file:

jQuery.fn.scroll() event shorthand is deprecated
JSON-to-JSONP auto-promotion is deprecated
@mgol
Copy link
Member

mgol commented Oct 16, 2021

Thanks for the report.

The first one is:
https://github.com/jquery/jquery-migrate/blob/main/warnings.md#jqmigrate-jqueryfnclick-event-shorthand-is-deprecated
Perhaps the message should be more generic.

The second one landed in #376 and it seems I forgot to add an entry in warnings.md.

@mgol mgol self-assigned this Oct 16, 2021
mgol added a commit to mgol/jquery-migrate that referenced this issue Dec 2, 2021
@mgol
Docs: Document the warning about the JSON-to-JSONP auto-promotion
84cbd62 
The warning landed in jquerygh-376 but I forgot to document it.

Fixes jquerygh-443
Ref jquerygh-376
@mgol mgol mentioned this issue Dec 2, 2021
Merged
@mgol
Copy link
Member

mgol commented Dec 2, 2021

OK, for the first issue, I'm not sure what can be improved. There are a lot of shorthands for events, listing them all would create a big list so the most common one - click - has been mentioned in the message. The rest are listed in the description of the warning.

As for the second one, I've submitted a PR: #447.

@mgol mgol closed this as completed in #447 Dec 30, 2021
mgol added a commit that referenced this issue Dec 30, 2021
@mgol @dmethvin
Docs: Document the warning about the JSON-to-JSONP auto-promotion
3ed29b0 
The warning landed in gh-376 but I forgot to document it.

Fixes gh-443
Closes gh-447
Ref gh-376

Co-authored-by: Dave Methvin <[email protected]>
@mgol mgol added this to the 3.3.3 milestone Dec 30, 2021
@mgol mgol modified the milestones: 3.3.3, 3.4.0 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgol mgol

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Docs: Document the warning about the JSON-to-JSONP auto-promotion mgol/jquery-migrate
2 participants
@mgol @Tiberriver256