diff --git a/knoten/shape.py b/knoten/shape.py index 441ab06..78a406a 100644 --- a/knoten/shape.py +++ b/knoten/shape.py @@ -5,7 +5,7 @@ class Ellipsoid: """ - A biaxial ellipsoid shape model. + A biaxial or triaxial ellipsoid shape model. """ def __init__(self, semi_major, semi_minor=None, median=None): @@ -15,9 +15,11 @@ def __init__(self, semi_major, semi_minor=None, median=None): Parameters ---------- semi_major : float - The equatorial semi-major radius of the ellipsoid. + Length of ellipsoid semi-axis along the x-axis. semi_minor : float - The polar semi-minor radius of the ellipsoid. + Length of ellipsoid semi-axis along the z-axis. + median : float + Length of ellipsoid semi-axis along the y-axis. """ self.a = semi_major self.b = semi_major @@ -34,7 +36,8 @@ def __init__(self, semi_major, semi_minor=None, median=None): def from_csm_sensor(cls, sensor): semi_major, semi_minor = csm.get_radii(sensor) return cls(semi_major, semi_minor) - + + def get_surface_normal(self, ground_pt): """ Given a ground point, calculate the surface normal. diff --git a/knoten/utils.py b/knoten/utils.py index 1165b85..cde4fe5 100644 --- a/knoten/utils.py +++ b/knoten/utils.py @@ -29,7 +29,6 @@ def sep_angle(a_vec, b_vec): : np.ndarray """ dot_prod = a_vec.x * b_vec.x + a_vec.y * b_vec.y + a_vec.z * b_vec.z - print(dot_prod) dot_prod /= magnitude(a_vec) * magnitude(b_vec) if(dot_prod >= 1.0): return 0.0