Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using "relative path theme" #534

Closed
murrple-1 opened this issue Mar 12, 2021 · 1 comment
Closed

Crash when using "relative path theme" #534

murrple-1 opened this issue Mar 12, 2021 · 1 comment

Comments

@murrple-1
Copy link

murrple-1 commented Mar 12, 2021

Running a command like resume export --theme "../jsonresume-theme-mytheme" --resume="./resume.json" .tmp/resume.pdf does not work. The docs seem to suggest this invocation is valid.

Assuming that is a valid use-case, the current code at render-html.js line 13 will not work, because path is undefined. This error is thrown in v3.0.4:

>> TypeError: Cannot read property 'join' of undefined
>>     at _default (/usr/lib/node_modules/resume-cli/build/render-html.js:24:28)
>>     at /usr/lib/node_modules/resume-cli/build/export-resume.js:107:48
>>     at createPdf (/usr/lib/node_modules/resume-cli/build/export-resume.js:131:5)
>>     at module.exports (/usr/lib/node_modules/resume-cli/build/export-resume.js:44:5)
>>     at Command.<anonymous> (/usr/lib/node_modules/resume-cli/build/main.js:67:5)
>>     at processTicksAndRejections (internal/process/task_queues.js:93:5)
>>     at async Promise.all (index 0)
>>     at async /usr/lib/node_modules/resume-cli/build/main.js:79:3 `createPdf` errored out
@murrple-1
Copy link
Author

Duplicate of #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant