Wrong module resolution

[fusionstrings]

Could be related with #10 .
Following is a simple reproduction
https://github.com/fusionstrings/jspm-resolve-test
https://glitch.com/~jspm-resolve-test

Here https://github.com/fusionstrings/jspm-resolve-test/blob/master/test.js I am trying to get resolved module type and despite being package.json.type : "module", /module.js is resolving to commonjs and missing module is not throwing error.

Based on my understanding is type is set to "module" it should resolve to js files as module.

[guybedford]

Did you try using jspm/jspm-resolve#master here?

…

On Mon, Dec 2, 2019 at 17:33 Dilip Kr. Shukla ***@***.***> wrote: Could be related with #10 <#10> . Following is a simple reproduction https://github.com/fusionstrings/jspm-resolve-test https://glitch.com/~jspm-resolve-test Here https://github.com/fusionstrings/jspm-resolve-test/blob/master/test.js I am trying to get resolved module type and despite being package.json.type : "module", /module.js is resolving to commonjs and missing module is not throwing error. Based on my understanding is type is set to "module" it should resolve to js files as module. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AAESFSWW5ECHUVSF735TWD3QWWEL7A5CNFSM4JULQOJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5PJ2JA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAESFSTSYJYYBENWGIVBUM3QWWEL7ANCNFSM4JULQOJA> .

[fusionstrings]

Sorry @guybedford no, I didn't use github master branch. I used the package from github master branch now.
It still didn't work.
I notice that the tests don't pass on master branch as well and throw same error.

 Error: Recursive symlink resolving 
      at Object.realpathSync (resolve.js:914:13)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)
      at Object.realpathSync (resolve.js:927:19)

Following is the check, which you may inspect
https://github.com/fusionstrings/jspm-resolve/pull/2/checks?check_run_id=331310229

I have also created a pull request against main repo. #19

[guybedford]

@fusionstrings you might need to ensure the parent is process.cwd() + path.sep.

The symlink issue looks like a bug to me that is unrelated, but would be good to fix too.

[fusionstrings]

Ok, so after a long debug session I managed to get it working but certainly at the core is conflict between npm install and jspm install. I will post the better finding ASAP.