Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive "slow types" #698

Open
uaeio opened this issue Aug 23, 2024 · 1 comment
Open

False positive "slow types" #698

uaeio opened this issue Aug 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@uaeio
Copy link

uaeio commented Aug 23, 2024

Package: https://jsr.io/@whiteand/cbor/score

I see low score, because of the 'Slow type'

But, I don't have slow types. My package has "isolatedDeclarations": true. And the jsr publish is successful.

@lionel-rowe
Copy link

lionel-rowe commented Aug 24, 2024

I'm having the same issue with https://jsr.io/@li/regexp-escape-polyfill/score (also I think you mean "false positive" 😉). I only export one function, which is explicitly marked with parameter and return types.

Is there any way of digging into "slow types" and other aspects of the score? deno publish --dry-run only shows green.

@uaeio uaeio changed the title False negative "slow types" False positive "slow types" Aug 27, 2024
@lucacasonato lucacasonato added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Needs Triage
Development

No branches or pull requests

3 participants