Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more javadocs would be helpful #1314

Open
Reissner opened this issue May 31, 2016 · 3 comments
Open

more javadocs would be helpful #1314

Reissner opened this issue May 31, 2016 · 3 comments

Comments

@Reissner
Copy link

I use JUnit for a while.
I also wrote a graphical wrapper for it, because i do not use the usual ide but emacs with jdee.
For people like me, more detailed javadocs would be helpful.

@marcphilipp
Copy link
Member

On which classes did you miss more detailed Javadoc?

@Reissner
Copy link
Author

Hi Marc,
the most basic ones.
E.g. Description is almost not at all described. equals and hashcode are
vital. testcount counts the atomic tests only and so on.
Failure: convenience methods are based on exception, docs would be helpful.
Result is quite subtile: is used in conjunction with
RunListener.testRunFinished.

Required is what goes into getIgnoreCount() (assumptions false?), what
goes into getRunCount (ignores no, assumptions false yes) and so on.
Also igores go into getFailureCount()

Taking all together, it is quite tricky:
In my opinion, getAssumptionsFailed() is missing.

Also RunListener: which methods are invoked by RunNotifier in which
ordering: not clear enough. I just found out
but docs would be better for sake of stability: I can never know whether
my observations are true by accident.

There is a lot like this.

I would like to suggest additional docs in close cooperation with an
experienced junit-developer.

Best Regards,

Ernst

On which classes did you miss more detailed Javadoc?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1314 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AE0OIH1cXhDsnIDPhZfEPY-jk_OuHgRrks5qHCc2gaJpZM4IqdMd.

@PeterWippermann
Copy link
Contributor

@Reissner Why don't you start a pull request and add the JavaDocs for a single class with the documentation you would have liked to see? Let's see, how this works :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants