Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add active cell border padding, remove double cell padding #7570

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add active cell border padding, remove double cell padding #7570

wants to merge 5 commits into from

Conversation

andrii-i
Copy link
Contributor

@andrii-i andrii-i commented Jan 29, 2025 •
edited
Loading

Add active cell left and right border padding, remove double cell left and right padding.

Code changes

Remove notebook-specific css rules that overwrite css rules inherited from JupyterLab on left and right border padding, cell left and right padding.

User-facing changes

Active cell left and right border padding is added, double padding around cells on left and right is removed.

Screenshots

Before (2nd screenshot is at 400% zoom):
Screenshot 2025-01-28 at 11 54 02 PM

Screenshot 2025-01-29 at 12 20 48 AM

After (2nd screenshot is at 400% zoom):
Screenshot 2025-01-28 at 11 52 51 PM

Screenshot 2025-01-29 at 12 18 50 AM

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch andrii-i/notebook/active-cell-border-padding

@andrii-i andrii-i marked this pull request as ready for review January 29, 2025 17:03
@andrii-i
Copy link
Contributor Author

please update snapshots

This was referenced Jan 29, 2025
Open
Open
@krassowski
Copy link
Member

No idea why action did not pick up your request above. Let me try:

bot please update galata snapshots

This was referenced Jan 29, 2025
Closed
Merged
@RRosio
Copy link
Collaborator

RRosio commented Jan 30, 2025 •
edited
Loading

Edit: Wow, I had a stale page and I did not see Mike's PR!

Hi @krassowski and @andrii-i, I saw this issue with the bot and tried looking into it. I see that the job was skipped and I thought it might be because of the author_association check that is made. I looked into the collaborators on the repo and I see neither of you are listed, which is strange because I thought you were both previously added (for triage, I believe?)... I can give it a try here to check, and I can add you as collaborators if that sounds good to you both.

bot please update galata snapshots

@RRosio
Copy link
Collaborator

RRosio commented Jan 30, 2025 •
edited
Loading

Sorry for the noise... I see now that Andrii is a member of the Notebook Council team and that Mike's PR adds checks for comment authors

@krassowski
Copy link
Member

krassowski commented Jan 30, 2025 •
edited
Loading

Thanks for the merge @RRosio! Maybe it has to do with write permissions? I do not have them on this repo. Let me try again:

bot please update galata snapshots

@RRosio if this does not get a 👍 from bot, can you try?

@krassowski
Copy link
Member

It worked! https://github.com/jupyter/notebook/actions/runs/13051242848

@krassowski
Copy link
Member

It looks like snapshots are also failing on main, possibly due to release of JupyterLab 4.4.0a3 which includes Console rework:

image

anyways, let's wait and see

@andrii-i
Copy link
Contributor Author

@krassowski @RRosio thank you both for looking into CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrii-i andrii-i

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add left and right padding to active cell border
3 participants
@andrii-i @krassowski @RRosio