-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docs in PRs ? #126
Comments
As far as I understand it is being built, for example with your PR #128 the built doc is https://jupyterlite-sphinx--128.org.readthedocs.build/en/128 |
Read the docs reports the doc build as part of the CI checks |
Yeah, but in case of failure, you can't see the logs as far as I Can tell. |
In case of failure, it should mark the check with a red cross and clicking on it should show you the logs. |
Yes, for example: |
Ah, thanks you are right. Feel free to close. I still have the impression that GitHub action is a bit more open into how docs are tested. Can readthedocs full configuration be in a readthedocs.yml file so that we can see how it tests docs ? |
The readthedocs configuration is at the root: https://github.com/jupyterlite/jupyterlite-sphinx/blob/main/.readthedocs.yml |
It looks to me that docs are not build in PRs,
I'm not sure how they are supposed to be build, but locally I had to change a couple of things like
yml
toyaml
for things to build.Maybe we should have a workflow checking that our docs build properly ?
The text was updated successfully, but these errors were encountered: