Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing translations to have default values #49

Open
ashleynolan opened this issue Aug 1, 2018 · 0 comments
Open

Allowing translations to have default values #49

ashleynolan opened this issue Aug 1, 2018 · 0 comments

Comments

@ashleynolan
Copy link
Contributor

Atm, there when we have shared global values (such as in the country selector in the footer) we have to duplicate those values for each set of translations.

It would be better if we could update the i18n handlebars helper to allow us to specify a default set such that:

{
  "default": {
    "countries": [
      {
        "flagUrl": "australiaFlagIconUrl",
        "siteUrl": "https://www.menulog.com.au"
      }
    ]
  }
}

And then if the value for a culture hasn't been set for this reference, it tries to access the default value before failing if no value has been set for either.

//cc @DamianMullins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant