Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When query result has rows with identical labels GET to /metric returns 500 #149

Open
daniel-anova opened this issue Feb 12, 2025 · 1 comment

Comments

@daniel-anova
Copy link

When doing a query that results in rows with identical values in the label columns, scrapping /metrics will return 500 with an error saying that it found duplicate values for metric.

This can make it extremely difficult to troubleshoot because there's no error on the logs and the duplication can be sporadic so in time sensitive queries constant monitoring is required to catch the failure and see the actual error by doing a manual GET to /metrics.

Exporter should be improved so that when there's duplicate rows a clear error log message should be emitted, ideally /metrics should still return 200 and just omit the duplicated metric but just having an error in the logs would prove to be a big benefit.

@dewey
Copy link
Member

dewey commented Feb 12, 2025

Indeed, that's not ideal. If someone wants to go ahead and implement that I'll happily merge that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants