From 1eb67d99ea671681d4a49e659abbe4dc4bc4976c Mon Sep 17 00:00:00 2001 From: "Mariany P." Date: Tue, 14 Jan 2025 08:17:38 -0500 Subject: [PATCH] fix: fix unintentional children mutation --- src/game/make.ts | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/game/make.ts b/src/game/make.ts index 18a8f04b..55b174b1 100644 --- a/src/game/make.ts +++ b/src/game/make.ts @@ -140,22 +140,16 @@ export function make(comps: CompList = []): GameObj { }, remove(obj: GameObj): void { - const idx = this.children.indexOf(obj); - - if (idx !== -1) { - obj.parent = null; - this.children.splice(idx, 1); + obj.parent = null; - const trigger = (o: GameObj) => { - o.trigger("destroy"); - _k.game.events.trigger("destroy", o); - o.children.forEach((child) => trigger(child)); - }; + const trigger = (o: GameObj) => { + o.trigger("destroy"); + _k.game.events.trigger("destroy", o); + o.children.forEach((child) => trigger(child)); + }; - trigger(obj); - } + trigger(obj); }, - // TODO: recursive removeAll(this: GameObj, tag?: Tag) { if (tag) {