Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of BaseParams in solrClient #41

Open
tokee opened this issue May 1, 2023 · 0 comments
Open

Better handling of BaseParams in solrClient #41

tokee opened this issue May 1, 2023 · 0 comments
Assignees
@tokee
Labels
enhancement New feature or request

Comments

@tokee
Copy link
Contributor

tokee commented May 1, 2023

The BaseParams for the solrClient is used for limiting the result set to material out of copyright. Unfortunately this overrides filters in SolrParams, requiring hacks to get around. The SolrBase should be refactored so that the clients are not directly accessible and the restriction filters should be applied explicitly in the available methods for issuing Solr requests. This should use addFilter instead of setFilter so that both request filters and copyright filters will be applied at the same time.
@tokee tokee added the enhancement New feature or request label May 1, 2023
@tokee tokee self-assigned this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tokee tokee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tokee