Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Flow trigger conditions in all plugin examples to no longer use Condition at the end #1990

Closed
anna-geller opened this issue Nov 28, 2024 · 3 comments
Closed

Adjust Flow trigger conditions in all plugin examples to no longer use Condition at the end #1990

anna-geller opened this issue Nov 28, 2024 · 3 comments
Assignees
@shrutimantri
Labels
area/docs Issues related to documentation, plugin examples, blueprints, and guides

Comments

@anna-geller
Copy link
Member

Description

Examples:

  • io.kestra.plugin.core.condition.ExecutionStatusCondition -> io.kestra.plugin.core.condition.ExecutionStatus
  • io.kestra.plugin.core.condition.ExecutionNamespaceCondition -> io.kestra.plugin.core.condition.ExecutionNamespace
  • io.kestra.plugin.core.condition.ExecutionLabelsCondition -> io.kestra.plugin.core.condition.ExecutionLabels
@kestrabot kestrabot bot added this to Issues Nov 28, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 28, 2024
@shrutimantri shrutimantri self-assigned this Nov 29, 2024
@anna-geller
Copy link
Member Author

done for notification plugins kestra-io/plugin-notifications@fa11d6d

This was referenced Jan 19, 2025
Merged
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Issues Jan 20, 2025
wrussell1999 added a commit that referenced this issue Jan 20, 2025
@wrussell1999
fix: #1990
3c34c5b
wrussell1999 added a commit that referenced this issue Jan 20, 2025
@wrussell1999
fix: #1990
fb9c74e
wrussell1999 added a commit that referenced this issue Jan 20, 2025
@wrussell1999
fix: #1990
a49b2a5
@wrussell1999
Copy link
Member

wrussell1999 commented Jan 20, 2025 •
edited
Loading

Just updated the docs to reflect the renaming. These should be what is being renamed in full:

  • io.kestra.plugin.core.condition.HasRetryAttemptCondition -> io.kestra.plugin.core.condition.HasRetryAttempt
  • io.kestra.plugin.core.condition.NotCondition -> io.kestra.plugin.core.condition.Not
  • io.kestra.plugin.core.condition.OrCondition -> io.kestra.plugin.core.condition.Or
  • io.kestra.plugin.core.condition.ExecutionFlowCondition -> io.kestra.plugin.core.condition.ExecutionFlow
  • io.kestra.plugin.core.condition.ExecutionNamespaceCondition -> io.kestra.plugin.core.condition.ExecutionNamespace
  • io.kestra.plugin.core.condition.ExecutionLabelsCondition -> io.kestra.plugin.core.condition.ExecutionLabels
  • io.kestra.plugin.core.condition.ExecutionStatusCondition -> io.kestra.plugin.core.condition.ExecutionStatus
  • io.kestra.plugin.core.condition.ExecutionOutputsCondition -> io.kestra.plugin.core.condition.ExecutionOutputs
  • io.kestra.plugin.core.condition.ExpressionCondition -> io.kestra.plugin.core.condition.Expression
  • io.kestra.plugin.core.condition.DateTimeBetweenCondition -> io.kestra.plugin.core.condition.DateTimeBetween
  • io.kestra.plugin.core.condition.DayWeekCondition -> io.kestra.plugin.core.condition.DayWeek
  • io.kestra.plugin.core.condition.DayWeekInMonthCondition -> io.kestra.plugin.core.condition.DayWeekInMonth
  • io.kestra.plugin.core.condition.WeekendCondition -> io.kestra.plugin.core.condition.Weekend
  • io.kestra.plugin.core.condition.PublicHolidayCondition -> io.kestra.plugin.core.condition.PublicHoliday
  • io.kestra.plugin.core.condition.TimeBetweenCondition -> io.kestra.plugin.core.condition.TimeBetween

@wrussell1999 wrussell1999 reopened this Jan 20, 2025
@github-project-automation github-project-automation bot moved this from Done to Backlog in Issues Jan 20, 2025
wrussell1999 added a commit that referenced this issue Jan 20, 2025
@wrussell1999
fix: add full list of conditions #1990
4ff74d1
@MilosPaunovic MilosPaunovic moved this from Backlog to In progress in Issues Jan 24, 2025
@anna-geller anna-geller added area/docs Issues related to documentation, plugin examples, blueprints, and guides and removed documentation labels Feb 10, 2025
@anna-geller
Copy link
Member Author

@shrutimantri are you still on it?

@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shrutimantri shrutimantri

Labels
area/docs Issues related to documentation, plugin examples, blueprints, and guides
Projects
Issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shrutimantri @wrussell1999 @anna-geller