Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of the Wire Protocol #18

Open
kevaundray opened this issue Aug 9, 2018 · 1 comment
Open

Review of the Wire Protocol #18

kevaundray opened this issue Aug 9, 2018 · 1 comment
Labels
Review Reviews that we will build up over time, encourages refactoring and revisiting old code

Comments

@kevaundray
Copy link
Owner

The wire protocol is now usable, however there are still things that I believe need to be implemented, some now and some further down the line:

MSGPING, MSGPONG: These will be used to verify that the node is still alive without having to do the handshake with it.

MSGReject: This is an important message for those looking to debug code, instead of silently disconnecting. The node will send a MSGReject stating why he has rejected the request.

MSGFilters: These will be implemented later down the line when either GCS/Bloom has been made.


This package has been designed so that the inner workings can be easily changed without the outsider having to edit their code if they rely upon it. I believe that optimisations can always be made and so this package should be visited periodically to review, add more tests and optimise.

@kevaundray
Copy link
Owner Author

Periodic Review:

The wire protocol is now usable and has been tested in a seed node implementation. In the future, it may refactored to allow versioning using go mod.

@kevaundray kevaundray added Review Reviews that we will build up over time, encourages refactoring and revisiting old code and removed Discussion labels Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Reviews that we will build up over time, encourages refactoring and revisiting old code
Projects
None yet
Development

No branches or pull requests

1 participant