Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Peers Package #23

Open
kevaundray opened this issue Sep 7, 2018 · 1 comment
Open

Review of Peers Package #23

kevaundray opened this issue Sep 7, 2018 · 1 comment
Labels
Review Reviews that we will build up over time, encourages refactoring and revisiting old code

Comments

@kevaundray
Copy link
Owner

This thread will be used to keep notes on the peers package

@kevaundray
Copy link
Owner Author

The Peers package is not fully finished as the PING/PONG commands are not implemented. Tests are finished for this class plus the inner stall detector struct that it embeds.

In terms of usability, I have not come across any problems. I do not see much reason for the Peers and Wire package to change much over time.

@kevaundray kevaundray added the Review Reviews that we will build up over time, encourages refactoring and revisiting old code label Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Reviews that we will build up over time, encourages refactoring and revisiting old code
Projects
None yet
Development

No branches or pull requests

1 participant