Attached files to google calendar are not visible from thunderbird (no warning)

[MLopez-Ibanez]

1. Create an event directly in Google Calendar and attach a file.
2. Sync with thunderbird.
3. The event as shown in thunderbird has no attachment and no indication that there is an attachment that is not accessible via thunderbird.

[Frank071]

In the code I see some parts commented out because 'no support in UI'. TB91 seems to support attachments. Isn't it as easy as enabling that code (line 543 in items.js) and setting attachments to true in manifest.json?

(I would have tried this myself, but I got caught in unsolvable differences between files in the official xpi and here on GitHub)

[kewisch]

The official xpi currently released is from the legacy branch. I've undergone a massive rewrite on the main branch, therefore you are seeing a few differences.w

As for the code in items.js you references (you mean this one, right?), that refers to video conferencing links. I'd rather have some dedicated UI that shows all of the conference info, instead of just hack in the URL.

Supporting other file attachments should be fairly simple. On the legacy branch, check out the JSONToEvent function that will read the information from Google. As for the ical properties to set, I'd model it loosely according to rfc8607. On the main branch, just add that ical property in a similar fashion as per rfc7265.

The Google Calendar API seems to also have a way to modify these, but since they can only be Google Drive attachments it may not be very useful. I'd suggest focusing on a readonly version for now, in that case we might also need some changes (or monkeypatching) in Thunderbird to not allow changes to attachments past their deletion.