Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Calendars not shown in "Select calendar" dialog when accepting an event invitation #715

Closed
MoralCode opened this issue Jan 18, 2024 · 8 comments

Comments

@MoralCode
Copy link

MoralCode commented Jan 18, 2024

Describe the problem and steps to reproduce it:

  1. Have a google account (in this case from an educational institution) and calendar configured in thunderbird
  2. receive an invite email (autogenerated by google when youre added as a participant) for an event started by someone else
  3. click "accept" in the navbar of the email
    Screenshot_20240118_094932

What happened?

Dialog pops up but no google-linked calendars are displayed in the list

What did you expect to happen?

Dialog pops up showing all writable calendars

Anything else we should know?

Debug log doesnt seem to show anything

Thunderbird: 115.6.1 (64-bit)
Gdata Provider: 115.0.2 (updated November 16, 2023)

Am happy to submit a PR if this is suspected to be a relatively newcomer-to-the-codebase type fix!

@MoralCode
Copy link
Author

MoralCode commented Jan 18, 2024

Possibly related to #563 and #664

@MoralCode
Copy link
Author

It looks like the events affected by this have somehow ended up on my calendar anyway, but I think that may be due to some automation on google's side to add invitations to my calendar and maybe not related to this issue

@kewisch
Copy link
Owner

kewisch commented Jan 25, 2024

Thanks for reporting! Are you subscribed to the primary calendar, the one with your name on it? This is the only calendar invitations can be accepted into. Do you maybe have multiple email addresses for that account? Do you have an email account/identity for each of those?

@kewisch kewisch added the needinfo Need more information label Jan 25, 2024
@MoralCode
Copy link
Author

I am subscribed to the primary calendar.

The institution has google apps configured weirdly on a different email domain (i.e. both [email protected] and [email protected] work for receiving email as far as im aware, but you need to use the g. one to sign into google for some reason. the primary account happens to be named using the g. address if that helps anything)

so yeah i guess I do have multiple email addresses/identities for that one gmail inbox (i have both @institution and @g.institution set up as identities that i can send from, but i almost always send using the first one)

Hope that helps!

@github-actions github-actions bot removed the needinfo Need more information label Jan 26, 2024
@kewisch
Copy link
Owner

kewisch commented Jan 28, 2024

Unfortunately I don't have a clear idea what the issue might be, but I can give you a few pointers on how to find out if you like. So first of all, the currently released codebase is on the legacy branch, and will be until I finally finish the rewrite.

The decision making on which calendars show up is done by the itip/imip code in Thunderbird. This in part uses some of the calendar properties here:

case "organizerId":
return "mailto:" + this.mCalendarName;
case "itip.transport":
if (
!this.isDefaultCalendar ||
!messenger.gdataSyncPrefs.get("settings.enableEmailInvitations", false)
) {
// If we explicitly return null here, then these calendars
// will not be included in the list of calendars to accept
// invitations to and imip will effectively be disabled.
return null;
}
break;
case "imip.identity.disabled":
// Disabling this hides the picker for identities in the new
// calendar wizard and calendar properties dialog. This should
// be done for all secondary calendars as they cannot accept
// invitations and if email invitations are generally disabled.
if (
!this.isDefaultCalendar ||
!messenger.gdataSyncPrefs.get("settings.enableEmailInvitations", false)
) {
return true;
}
break;
}

I'd suggest starting there by setting a breakpoint and checking which code path itip.transport and imip.identity.disabled take. You'll need to use the main process debugger, not the add-on debugger. Find it in tools > Developer Tools > Developer Toolbox.

Let me know if this works for you!

@kewisch kewisch added the needinfo Need more information label Jan 28, 2024
@MoralCode
Copy link
Author

based on the looks of that code and some basic testing in the debugger, it seems like the cause is that messenger.gdataSyncPrefs.get("settings.enableEmailInvitations", false) line, which is using a default value of false. I dont see that setting set by default in the about:config menu and setting it doesnt seem to change anything. I also cant find any related settings in the addon specific preferences.

Is there a way to modify this setting somewhere? or is this something that was possible in a previous verison?

Happy to wait for the rewrite if that helps make things easier

@github-actions github-actions bot removed the needinfo Need more information label Jan 29, 2024
@kewisch
Copy link
Owner

kewisch commented Feb 24, 2024

You should be able to change this setting in the add-on preferences, can you take a look?

@kewisch kewisch added the needinfo Need more information label Feb 24, 2024
Copy link

It looks like we haven't heard back on this issue, therefore we are closing this issue. If this problem persists in the latest version of Thunderbird and the Provider for Google Calendar, please re-open this issue.

@github-actions github-actions bot removed the needinfo Need more information label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants