-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events added from Thunderbird are publicly visible #749
Comments
Hi Dominique, thanks for reporting. Could you add some logging info with logging enabled, during the time the event is imported into your calendar, and maybe attach the redacted .eml from the invitation? |
I needed to wait till I got another invitation (each can be used only once). |
I reproduced the problem. A sanitized log is attached. console-export-2024-5-27_16-28-0.txt The bug did not occur when I had created a local Thunderbird calendar, and two Google calendars. and added an event to the first of the Google calendars. But when I deleted the local calendar (only the two Google calendars left), the bug occurred when adding to the first calendar. Of course there might be other variables that changed between the two experiments. |
Can you also attach or check the actual invitation email sources? If the contained event has |
You are right! The event did contain CLASS:PUBLIC: I'm not attaching the whole email here because it was too difficult to sanitize. I added the base64-decoded ICS from the mail source. I assume it comes from creating an invite from an MS Exchange calendar or similar. One of the headers in the mail is:
So it seems clarified why the calendar events are public. But this leaves the question whether they should be public. I can't see a good reason why the inviting person should control the visibility of an event in the invited person's calendar. And additionally, I assume that this is not done intentionally, but is a bug (or at least strange behavior) of MS Exchange. Since it is unlikely that we can get MS to fix that, I think the best would be to add all event with the default visibility (i.e. strip out the CLASS:PUBLIC). Otherwise there is a high risk of leaking confidential information. |
What happens if you accept the event from within the Gmail web UI? Is the imported event public or default? |
There need to be a few values set w.r.t. organizers, attendees, and some headers, if this doesn't match it won't show. Maybe you could replicate as follows:
|
I managed to follow those steps.
(XXXXXXX marks privatized parts in the snippets below) The base64-decoded event was:
The event exported from the calendar was
|
Alright, thanks. I'd consider this an enhancement to remove certain props for invitations, but acknowledging it would be great to have! |
Describe the problem and steps to reproduce it:
When I add an event from an invitation, it has public visibility in Google calendar.
Steps:
What happened?
The event is visible to everyone who has a link to the calendar, even if they were only given a link to the free/busy view.
What did you expect to happen?
Events are created with "Default visibility" (or it should be configurable).
Anything else we should know?
The text was updated successfully, but these errors were encountered: