Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Keyboard list navigation improved #215

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

micz
Copy link
Contributor

@micz micz commented Feb 13, 2025

See #209.
Not including aria elements as agreed.

@micz
Copy link
Contributor Author

micz commented Feb 15, 2025

At the moment, with each update of the list, if the selected item still exists, it remains selected. Using this feature daily, I was wondering whether it might be better to add an option to always select the first item with each update. What do you think?

@micz
Copy link
Contributor Author

micz commented Feb 28, 2025

I changed the code in this way:

  • Using the observer to select the first line when opening the popup, then the observer is disconnected.
  • Selecting the first line when searching directly in the repopulate() method.

The question in #215 (comment) is still valid.

@kewisch kewisch merged commit a89bb39 into kewisch:main Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants