Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLATFORM: Unnecessary Scrollbar During Skeleton Loading & UI Issue with Switch #744

Open
Allan2000-Git opened this issue Feb 11, 2025 · 13 comments · May be fixed by #750
Open

PLATFORM: Unnecessary Scrollbar During Skeleton Loading & UI Issue with Switch #744

Allan2000-Git opened this issue Feb 11, 2025 · 13 comments · May be fixed by #750
Labels
difficulty: 1 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: medium scope: platform Everything related to the keyshade platform package type: bug Something isn't working

Comments

@Allan2000-Git
Copy link
Contributor

Describe the bug

  1. Unnecessary Scrollbar Appearing During Skeleton Loading
  • When loading, skeletons are displayed along with a scrollbar that scrolls unnecessarily.
  • This causes an unintended UI shift, affecting user experience.
  1. UX Issue with Switch Component
  • The slider of the switch component maybe affected in some way. Need to avoid it overflowing the container width.

To Reproduce
Steps to reproduce the behavior:

  1. Open the page where skeleton loaders appear (ex: variables page)
  2. Observe the scrollbar appearing while skeletons are loading.
  3. Once content loads, the scrollbar behavior changes.

Expected behavior

  • Skeleton loaders should not trigger a scrollbar; instead, overflow: auto should be used.
  • The switch component should provide a clearer state transition with improved UX.

Screenshots
Overflow:

Image

Switch:

Image
Image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version Latest
@rajdip-b rajdip-b added type: bug Something isn't working good first issue Good for newcomers scope: platform Everything related to the keyshade platform package priority: medium difficulty: 1 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag labels Feb 12, 2025
@Allan2000-Git Allan2000-Git changed the title PLATFORM: Unnecessary Scrollbar During Skeleton Loading & UX Issue with Switch PLATFORM: Unnecessary Scrollbar During Skeleton Loading & UI Issue with Switch Feb 12, 2025
@chetan102
Copy link

/attempt

@github-actions GitHub Actions
Copy link

Assigned the issue to @chetan102!

@chetan102 chetan102 linked a pull request Feb 12, 2025 that will close this issue
Open
@rajdip-b
Copy link
Member

hey @chetan102, i see that you have a lot of FOSS issues in your attempt. I would need to unassign this for now to let others have a chance. If no one picks it up within the window, you are free to attempt.

@chetan102
Copy link

chetan102 commented Feb 12, 2025 •
edited
Loading

@rajdip-b But i already adddd the Pr for it

@rajdip-b
Copy link
Member

Ah dang! Okay. But do you want to do it on behalf of FOSS? If so, you shouldn't be putting up PRs right away.

@himanshuchitoria
Copy link

/attempt

@github-actions GitHub Actions
Copy link

Assigned the issue to @himanshuchitoria!

@prasanthoyasco
Copy link

Is this issue resolved?

@rajdip-b
Copy link
Member

Hey man, no it's still in works. Since its the hack season, we have a ton of issues assigned to people, and we will have to wait atleast until tomorrow to check on the progress. If it's still not solved, we would probably unassign people.

@himanshuchitoria
Copy link

The issue probably be solved by tomorrow

@github-actions GitHub Actions
Copy link

@himanshuchitoria, please open a draft PR linking this issue!

@github-actions GitHub Actions
Copy link

@himanshuchitoria, please open a draft PR linking this issue; otherwise you will be unassigned from this issue after Thu Feb 27 2025 10:26:30 GMT+0000 (Coordinated Universal Time)!

@github-actions GitHub Actions
Copy link

Unassigned the issue from @himanshuchitoria due to inactivity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: 1 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: medium scope: platform Everything related to the keyshade platform package type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Skeleton scrollbar issue chetan102/keyshade
5 participants
@Allan2000-Git @prasanthoyasco @chetan102 @rajdip-b @himanshuchitoria