Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM: Ability to reveal value of secret #773

Open
4 tasks
rajdip-b opened this issue Feb 21, 2025 · 8 comments · May be fixed by #825
Open
4 tasks

PLATFORM: Ability to reveal value of secret #773

rajdip-b opened this issue Feb 21, 2025 · 8 comments · May be fixed by #825
Assignees
Labels
difficulty: 3 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: high scope: platform Everything related to the keyshade platform package type: enhancement New feature or request

Comments

@rajdip-b
Copy link
Member

Description

Secrets should ideally be shown in hidden format. Conditionally, they should be displayed.

The project optionally stores the private key in the DB. Right now, setting decryptValue=true while fetching secrets will automatically decrypt the values if the private key is present. The default should be not to auto decrypt the values while fetching secrets. Decryption should take place in client side.

Secrets can be revealed if:

  • the project stores the private key (can be fetched from selectedProjectAtom)
  • the project doesn't store the private key, but the key has been set locally in the browser's context (a feature still under works)
    If any of the above conditions satisfy, we will decrypt the value of the secret in the browser using the private key and show users the value

If none of these conditions satisfy, we don't allow the users to show the plaintext value of the secret.

Solution

Checklist

  • Remove auto decrypting while fetching secrets
  • Add the decryption utility function under lib in platform
  • Add the UI changes from figma
  • Make sure the changes comply with the rules specified
@rajdip-b rajdip-b added difficulty: 3 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: high scope: platform Everything related to the keyshade platform package type: enhancement New feature or request labels Feb 21, 2025
@harshsoni-harsh
Copy link

/attempt

Copy link

Assigned the issue to @harshsoni-harsh!

Copy link

@harshsoni-harsh, please open a draft PR linking this issue!

Copy link

github-actions bot commented Mar 5, 2025

@harshsoni-harsh, please open a draft PR linking this issue; otherwise you will be unassigned from this issue after Fri Mar 07 2025 16:18:04 GMT+0000 (Coordinated Universal Time)!

Copy link

github-actions bot commented Mar 7, 2025

Unassigned the issue from @harshsoni-harsh due to inactivity!

@Souvik9205
Copy link
Contributor

/attempt

Copy link

Assigned the issue to @Souvik9205!

Copy link

@Souvik9205, please open a draft PR linking this issue!

@Souvik9205 Souvik9205 linked a pull request Mar 13, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 3 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: high scope: platform Everything related to the keyshade platform package type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants