Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koa v3 Tracker #1837

Open
4 of 10 tasks
jonathanong opened this issue Aug 29, 2024 · 5 comments · May be fixed by #1845
Open
4 of 10 tasks

Koa v3 Tracker #1837

jonathanong opened this issue Aug 29, 2024 · 5 comments · May be fixed by #1845

Comments

@jonathanong
Copy link
Member

jonathanong commented Aug 29, 2024

Starting a new tracker for v3

Milestone: https://github.com/koajs/koa/milestone/4

Other Breaking Changes:

Tests:

  • Migrate to jest
  • Properly close down server after each test run

Improved Documentation:

@jaydenseric
Copy link

Regarding the goal to move to Jest; please don't. Use the native Node.js test runner! It should be more than adequate.

You can pair it with coverage-node, a very lightweight CLI tool, to enforce 100% code coverage in tests:

https://github.com/jaydenseric/coverage-node

@talentlessguy
Copy link

to add, Node test runner has identical API to Jest

for assertion, node:assert could be used

@benmccann
Copy link

Vitest is another fairly lightweight option for jest-compatible test runner. My last experience was that Jest is terrible to use with ESM as it doesn't fully support it yet. vitest is much better in this regard.

A rewrite might also be a nice time to take a look at including only minimal dependencies (e.g. https://npmgraph.js.org/?q=koa vs https://npmgraph.js.org/?q=polka)

@jonathanong
Copy link
Member Author

I just realized that I already migrated it to jest a while go haha. if anyone is interested in migrating to node's official test runner, that would be great. otherwise, I will leave it as is

@iietmoon
Copy link

We are in love in koa, and such good thing we go with roadmap for v3 and contribute for fixing some issues, since we work too in our web framework "Mavro" and Koa has big hand on core of it,
if someone want to contribute will be good to go with us https://discord.gg/jJK5kZx84B

@sirenkovladd sirenkovladd linked a pull request Sep 20, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants