feat: Add upstream response header passthrough #17
+68
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the upstream server's `subscription-userinfo`, `profile-update-interval`, and `profile-web-page-url` response headers to the client. - Modify `getParsedSubData.ts` to return the parsed data and upstream response headers. - Modify `clash-meta.js`, `debug.js`, `share-link.js`, and `sing-box.js` to merge upstream response headers into the final response headers.
|
This area of the code is designed that way, rather than passing them through BECAUSE we can't know which set of input headers should be as we are expected multiple input source. Your current changes overwrite these headers EVERY time when processing the inputed headers, effectively only preserving the last upstream header, which deviates from the intended behavior. (If my rough review right) This PR might be in draft status, but thank you for your collaboration. Will do further review when i have the time. |
|
I just think that passing through remote subscription information is a useful requirement. You can make any modifications or even close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscription-userinfo,profile-update-interval, andprofile-web-page-urlresponse headers to the client.getParsedSubData.tsto return the parsed data and upstream response headers.clash-meta.js,debug.js,share-link.js, andsing-box.jsto merge upstream response headers into the final response headers.Fixed: #15