Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing incidents on the file after accepting resolution for one of the incidents #122

Closed
savitharaghunathan opened this issue Feb 26, 2025 · 3 comments · Fixed by #123 or konveyor/editor-extensions#417
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@savitharaghunathan
Copy link
Member

I have three incidents in the file, one of which was triggered by a custom rule.

Image After resolving the following issue:

The sun.misc.BASE64Encoder class has been removed. It can be replaced with the Base64.Encoder class instantiated using the java.util.Base64.getMimeEncoder() method. For further examples on replacing BASE64Encoder with Base64.Encoder, refer to the "Code example" link below.

and accepting the resolution, the incident triggered by the custom rule is no longer listed after re-running the analysis.

Image

When I stopped the server, deleted the logs folder, restarted the server, and re-ran the analysis, the custom rule violation reappeared.

Image

Note: When I ran Kantra to verify locally, I could still see the incident triggered by the custom rule.

@savitharaghunathan savitharaghunathan changed the title Missing incidents on the file after accepting a resolution Missing incidents on the file after accepting resolution for one of the incidents Feb 26, 2025
@savitharaghunathan
Copy link
Member Author

custom rule link - https://github.com/savitharaghunathan/migrationex/blob/main/rules/rule.yaml
app link - https://github.com/savitharaghunathan/migrationex/tree/main

settings.json

{
    "konveyor.analysis.customRules": [
        "/Users/sraghuna/local_dev/rules"
    ],
    "konveyor.analysis.useDefaultRulesets": true,
    "konveyor.analysis.labelSelector": "(konveyor.io/target=jakarta-ee || konveyor.io/target=openjdk11 || konveyor.io/target=openjdk17) || (discovery)",
    "konveyor.kai.traceEnabled": true,
}

@shawn-hurley shawn-hurley transferred this issue from konveyor/editor-extensions Feb 26, 2025
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 26, 2025
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. label Feb 26, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Feb 26, 2025
@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Feb 26, 2025
@shawn-hurley
Copy link
Contributor

I am moving this issue because the problem is in the java analyzer bundle filtering out a search match for the custom rule.

Going to dig in more tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: Done
Status: ✅ Done
2 participants