Added allowExtraKeys parameter

Signed-off-by: RJ Garcia <[email protected]>

Author: RJ Garcia

README.md

@@ -171,6 +171,8 @@ Original RFC Pull Request to Symfony: https://github.com/symfony/symfony/issues/
 
 No formal API documentation is setup, but the src dir is under 200loc at this point. Also the tests directory gives a good overview of the various features as well.
 
+- [Symfony Config Feature Tests](./test/feature/SymfonyConfigTest.php)
+
 ## Testing
 
 Run `composer test` to run the test suite.

src/ProcessSchema/SymfonyConfig/process-schema.php

@@ -30,6 +30,10 @@ function configureNode(NodeParentInterface $configNode, Node $node): void {
             throw new \RuntimeException('Unexpected dict node type.');
         }
 
+        if ($node->attribute('allowExtraKeys')) {
+            $resNode->ignoreExtraKeys(false);
+        }
+
         foreach ($node->attribute('nodesByName') ?? [] as $name => $childConfigNode) {
             configureNode($resNode->children(), $childConfigNode->withAddedAttributes(['name' => $name]));
         }
@@ -59,7 +63,6 @@ function configureNode(NodeParentInterface $configNode, Node $node): void {
         }
         /** @var ArrayNodeDefinition $resNode */
         if ($node->is('dict')) {
-            $resNode->ignoreExtraKeys();
             $resNode->useAttributeAsKey($node->attribute('attribute_key') ?? 'key');
         }
         configureArrayNode($resNode, $node->attribute('node'));

test/feature/SymfonyConfigTest.php

@@ -4,18 +4,13 @@
 
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
-use Symfony\Component\Config\Definition\Dumper\YamlReferenceDumper;
 use function Krak\Schema\ProcessSchema\SymfonyConfig\configTree;
 
 final class SymfonyConfigTest extends \PHPUnit\Framework\TestCase
 {
     /** @dataProvider provide_config_trees */
     public function test_processing_of_schema_to_config_tree(TreeBuilder $expected, TreeBuilder $actual) {
-        $dumper = new YamlReferenceDumper();
-        $this->assertEquals(
-            $dumper->dumpNode($expected->buildTree()),
-            $dumper->dumpNode($actual->buildTree())
-        );
+        $this->assertEquals($expected->buildTree(), $actual->buildTree());
     }
 
     public function provide_config_trees() {
@@ -101,7 +96,7 @@ public function provide_config_trees() {
             ])),
         ];
 
-        yield 'tree with ignoreExtraKeys' => [
+        yield 'tree with custom configuration' => [
             (new TreeBuilder('root'))->getRootNode()
                 ->ignoreExtraKeys()
                 ->children()
@@ -113,6 +108,18 @@ public function provide_config_trees() {
             ], [ 'configure' => function($def) {  $def->ignoreExtraKeys(); } ]))
         ];
 
+        yield 'tree with allowExtraKeys' => [
+            (new TreeBuilder('root'))->getRootNode()
+                ->ignoreExtraKeys(false)
+                ->children()
+                    ->integerNode('int')->end()
+                ->end()
+            ->end(),
+            configTree('root', struct([
+                'int' => int(),
+            ], ['allowExtraKeys' => true]))
+        ];
+
         yield 'tree with configured array nodes' => [
             (new TreeBuilder('root'))->getRootNode()
                 ->children()
@@ -135,7 +142,6 @@ public function provide_config_trees() {
             (new TreeBuilder('root'))->getRootNode()
                 ->children()
                     ->arrayNode('dict')
-                        ->ignoreExtraKeys()
                         ->useAttributeAsKey('key')
                         ->scalarPrototype()->end()
                     ->end()