Fix typescript defs

theogravity · theogravity · commit 2d2d10143cf4 · 2020-03-22T04:58:17.000-07:00
diff --git a/README.md b/README.md
@@ -41,7 +41,7 @@
 
 ```sh
 # v4 of sqlite is targted for nodejs 10 and on.
-$ npm install sqlite@4.0.0-beta.1 --save
+$ npm install sqlite@4.0.0-beta.4 --save
 
 # If you need a legacy version for an older version of nodejs
 # install v3 instead, and look at the v3 branch readme for usage details
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "sqlite",
-  "version": "4.0.0-beta.1",
+  "version": "4.0.0-beta.4",
   "description": "SQLite client for Node.js applications with SQL-based migrations API written in Typescript",
   "main": "build/index.js",
   "types": "build/index.d.ts",
diff --git a/src/interfaces/Sqlite3.interfaces.ts b/src/interfaces/Sqlite3.interfaces.ts
@@ -68,9 +68,3 @@ export namespace Sqlite3 {
     changes?: number
   }
 }
-
-declare module 'sqlite3' {
-  interface Database {
-    loadExtension(path: string, callback?: (err) => void)
-  }
-}
diff --git a/src/sqlite3/Sqlite3Database.ts b/src/sqlite3/Sqlite3Database.ts
@@ -298,6 +298,9 @@ export class Sqlite3Database {
    */
   loadExtension (path: string) {
     return new Promise((resolve, reject) => {
+      // @todo if anyone can augment the typescript defs for loadExtension
+      // feel free to open a PR!
+      // @ts-ignore
       this.db.loadExtension(path, err => {
         if (err) {
           return reject(err)

-Original file line number
+Diff line change
 ```sh
 # v4 of sqlite is targted for nodejs 10 and on.
 -$ npm install [email protected].1 --save
 +$ npm install [email protected].4 --save
 # If you need a legacy version for an older version of nodejs
 # install v3 instead, and look at the v3 branch readme for usage details
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "sqlite",`
`3`		`- "version": "4.0.0-beta.1",`
	`3`	`+ "version": "4.0.0-beta.4",`
`4`	`4`	`"description": "SQLite client for Node.js applications with SQL-based migrations API written in Typescript",`
`5`	`5`	`"main": "build/index.js",`
`6`	`6`	`"types": "build/index.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,3 @@ export namespace Sqlite3 {`
`68`	`68`	`changes?: number`
`69`	`69`	`}`
`70`	`70`	`}`
`71`		`-`
`72`		`-declare module 'sqlite3' {`
`73`		`- interface Database {`
`74`		`- loadExtension(path: string, callback?: (err) => void)`
`75`		`- }`
`76`		`-}`